Support disabling weak type checking #16968

Activity

1. smhc commented on Jul 6, 2017

   

   smhc

   on Jul 6, 2017

   Last edited by smhc

   Author

   More actions

   Some further discussion of this is located here: ag-grid/ag-grid#1708

   I thought weak type 'implements' may still be useful for code like the below. However typescript doesn't actually pick this up as an error. I think it would be helpful if it did, and weak type implements should be allowed if so.

   // Library code
   
   interface IDisposable {
       // implement if you want custom dispose code
       dispose?: () => boolean;
   }
   
   class DefaultThing implements IDisposable {
       // doesn't require custom dispose, but extenders should implement it correctly if they do
       public work(): number {
           return 0;
       }
   }
   
   // Project code
   
   class MyThing extends DefaultThing {
       // want to inherit 'work()', but also the type checking of 'dispose(): boolean'
       public dispose(): string {  // want an error here
           return '';
       }
   }
2. RyanCavanaugh commented on Jul 6, 2017

   

   Ryan Cavanaugh (RyanCavanaugh)

   on Jul 6, 2017

   Member

   More actions

   The referenced issue has an explanation from me of what you should be doing in that case.
3. smhc commented on Jul 7, 2017

   

   smhc

   on Jul 7, 2017

   Author

   More actions

   Closing this issue as it is discussed elsewhere.
   Will wait to see if many others are hit by the same problem that prevents being able to upgrade before following it up further.
4. smhc

   closed this as completedon Jul 7, 2017
5. microsoft

   locked and limited conversation to collaborators on Jun 14, 2018