Skip to content

Maximum call stack size exceeded for getTypeAtFlowNode in Large File #14314

Closed
Closed
Maximum call stack size exceeded for getTypeAtFlowNode in Large File#14314
Assignees
ahejlsberg
Labels
BugA bug in TypeScriptFixedA PR has been merged for this issue
Milestone
TypeScript 2.6

Description

@mattbierner
Matt Bierner (mattbierner)
opened on Feb 26, 2017

TypeScript Version: 2.2.1 / nightly (2.2.0-dev.201xxxxx)

Code
Discovered while trying to work around react/react-native#12590

For a large TS file that looks like:

const data = {} as any

data["a"] = "AH0";
data["a(1)"] = "EY1";
data["a's"] = "EY1 Z";
data["a."] = "EY1";
data["a.'s"] = "EY1 Z";
data["a.s"] = "EY1 Z";
... 100,000 + lines

Compile the file on its own with tsc

Here's the complete file: https://gist.githubusercontent.com/mattbierner/34dbc249be0ebddedcc275d0ff40281b/raw/985dbbfba9a5db89f9cea618ce3c885ccc46ef8b/cmu.js

Bug

/XXX/node_modules/typescript/lib/tsc.js:51296
                throw e;
                ^

RangeError: Maximum call stack size exceeded
    at isMatchingReference (/XXX/node_modules/typescript/lib/tsc.js:27613:37)
    at getTypeAtFlowAssignment (/XXX/node_modules/typescript/lib/tsc.js:28150:21)
    at getTypeAtFlowNode (/XXX/node_modules/typescript/lib/tsc.js:28101:32)
    at getTypeAtFlowArrayMutation (/XXX/node_modules/typescript/lib/tsc.js:28178:36)
    at getTypeAtFlowNode (/XXX/node_modules/typescript/lib/tsc.js:28123:32)
    at getTypeAtFlowArrayMutation (/XXX/node_modules/typescript/lib/tsc.js:28178:36)
    at getTypeAtFlowNode (/XXX/node_modules/typescript/lib/tsc.js:28123:32)
    at getTypeAtFlowArrayMutation (/XXX/node_modules/typescript/lib/tsc.js:28178:36)
    at getTypeAtFlowNode (/XXX/node_modules/typescript/lib/tsc.js:28123:32)
    at getTypeAtFlowArrayMutation (/XXX/node_modules/typescript/lib/tsc.js:28178:36)

Activity

  1. mhegazy commented on Feb 27, 2017

    @mhegazy
    Mohamed Hegazy (mhegazy)
    on Feb 27, 2017
    Contributor

    Every statement is considered a "narrowing" expression, and that triggers more analysis, if the compiler goes far enough in the statement list, it runs out of stack space.

    have you considered writing it as an object literal?

    const data = {
    "a": "AH0",
    "a(1)": "EY1",
    "a's": "EY1 Z",
    "a.": "EY1",
    "a.'s": "EY1 Z",
    "a.s": "EY1 Z",
    ...
}

    or adding a type annotation with an index signature, e.g. : { [x:string}: string }

  2. mjbvz commented on Feb 28, 2017

    @mjbvz
    Matt Bierner (mjbvz)
    on Feb 28, 2017
    Contributor

    Thanks Mohamed Hegazy (@mhegazy). I actually started with a json object but ran into some problems with react-native, which is why I tried to convert it to this format. Obviously the code is not terribly practical, but I also wasn't trying to break typescript or anything when doing this.

    Adding an index signiture like so:

    const data: { [index: string]: string} = {}
...

    Does not fix things. I still see exceptions such as:

    Error - 8:57:45 PM] 'quickinfo' request failed with error.
Error processing request. Maximum call stack size exceeded
RangeError: Maximum call stack size exceeded
    at Object.isBindingPattern (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/extensions/typescript/node_modules/typescript/lib/tsserver.js:8117:30)
    at walkUpBindingElementsAndPatterns (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/extensions/typescript/node_modules/typescript/lib/tsserver.js:8700:49)
    at Object.getCombinedNodeFlags (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/extensions/typescript/node_modules/typescript/lib/tsserver.js:8722:16)
    at Object.isBlockOrCatchScoped (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/extensions/typescript/node_modules/typescript/lib/tsserver.js:5394:20)
    at /Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/extensions/typescript/node_modules/typescript/lib/tsserver.js:21992:88
    at Object.forEach (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/extensions/typescript/node_modules/typescript/lib/tsserver.js:1220:30)
    at checkResolvedBlockScopedVariable (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/extensions/typescript/node_modules/typescript/lib/tsserver.js:21992:34)
    at resolveName (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/extensions/typescript/node_modules/typescript/lib/tsserver.js:21909:25)
    at getResolvedSymbol (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/extensions/typescript/node_modules/typescript/lib/tsserver.js:28697:67)
    at isMatchingReference (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/extensions/typescript/node_modules/typescript/lib/tsserver.js:28743:80)

    and

    [Error - 8:58:14 PM] 'completions' request failed with error.
Error processing request. Maximum call stack size exceeded
RangeError: Maximum call stack size exceeded
    at Object.isBindingPattern (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/extensions/typescript/node_modules/typescript/lib/tsserver.js:8117:30)
    at walkUpBindingElementsAndPatterns (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/extensions/typescript/node_modules/typescript/lib/tsserver.js:8700:49)
    at Object.getCombinedNodeFlags (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/extensions/typescript/node_modules/typescript/lib/tsserver.js:8722:16)
    at Object.isBlockOrCatchScoped (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/extensions/typescript/node_modules/typescript/lib/tsserver.js:5394:20)
    at /Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/extensions/typescript/node_modules/typescript/lib/tsserver.js:21992:88
    at Object.forEach (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/extensions/typescript/node_modules/typescript/lib/tsserver.js:1220:30)
    at checkResolvedBlockScopedVariable (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/extensions/typescript/node_modules/typescript/lib/tsserver.js:21992:34)
    at resolveName (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/extensions/typescript/node_modules/typescript/lib/tsserver.js:21909:25)
    at getResolvedSymbol (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/extensions/typescript/node_modules/typescript/lib/tsserver.js:28697:67)
    at isMatchingReference (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/extensions/typescript/node_modules/typescript/lib/tsserver.js:28743:80)
  3. Mohamed Hegazy (mhegazy)
    added
    BugA bug in TypeScript
    on Feb 28, 2017
  4. Mohamed Hegazy (mhegazy)
    assigned
    Nathan Shively-Sanders (sandersn)
    on Feb 28, 2017
  5. Mohamed Hegazy (mhegazy)
    added this to the TypeScript 2.3 milestone on Feb 28, 2017
  6. Mohamed Hegazy (mhegazy)
    assigned
    Nathan Shively-Sanders (sandersn)
    and unassigned
    Nathan Shively-Sanders (sandersn)
    on Mar 24, 2017
  7. Mohamed Hegazy (mhegazy)
    added
    BugA bug in TypeScript
    and removed
    BugA bug in TypeScript
    on Mar 24, 2017
  8. Mohamed Hegazy (mhegazy)
    removed this from the TypeScript 2.3 milestone on Mar 24, 2017

  9. atifsyedali commented on Jun 13, 2017

    @atifsyedali
    Atif Ali (atifsyedali)
    on Jun 13, 2017

    This is particularly problematic because it tends to break long locale files in large projects.

  10. endel commented on Aug 4, 2017

    @endel
    Endel Dreyer (endel)
    on Aug 4, 2017

    Still occurring on typescript@2.4.2.

    As Atif Ali (@atifsyedali) said, this is quite problematic. I'm working with legacy code that has +5000 lines of assignments to a dictionary.

    /XXX/node_modules/typescript/lib/tsc.js:55776
                throw e;
                ^

RangeError: Maximum call stack size exceeded
    at isMatchingReference (/XXX/node_modules/typescript/lib/tsc.js:30445:37)
    at isMatchingReference (/XXX/node_modules/typescript/lib/tsc.js:30458:25)
    at getTypeAtFlowArrayMutation (/XXX/node_modules/typescript/lib/tsc.js:31030:21)
    at getTypeAtFlowNode (/XXX/node_modules/typescript/lib/tsc.js:30976:32)
    at getTypeAtFlowArrayMutation (/XXX/node_modules/typescript/lib/tsc.js:31031:36)
    at getTypeAtFlowNode (/XXX/node_modules/typescript/lib/tsc.js:30976:32)
    at getTypeAtFlowArrayMutation (/XXX/node_modules/typescript/lib/tsc.js:31031:36)
    at getTypeAtFlowNode (/XXX/node_modules/typescript/lib/tsc.js:30976:32)
    at getTypeAtFlowArrayMutation (/XXX/node_modules/typescript/lib/tsc.js:31031:36)
    at getTypeAtFlowNode (/XXX/node_modules/typescript/lib/tsc.js:30976:32)

  11. endel commented on Aug 4, 2017

    @endel
    Endel Dreyer (endel)
    on Aug 4, 2017

    As a workaround, I'm using arrays and assigning later to the dictionary:

    let dict: any = {};

let values = [
  ["key", "value"],
  ["key", "value"],
  // ... 5000+ entries
];

for (let i=0; i<values.length; i++) {
  dict[ values[i][0] ] = values[i][1];
}
  12. Daniel Rosenwasser (DanielRosenwasser)
    added this to the milestone on Aug 4, 2017
  13. Daniel Rosenwasser (DanielRosenwasser)
    assigned
    Anders Hejlsberg (ahejlsberg)
    and unassigned
    Nathan Shively-Sanders (sandersn)
    on Aug 4, 2017
  14. Mohamed Hegazy (mhegazy)
    added
    FixedA PR has been merged for this issue
    and removed
    FixedA PR has been merged for this issue
    on Aug 16, 2017
  15. Mohamed Hegazy (mhegazy)
    modified the milestones: TypeScript 2.6, on Aug 16, 2017
  16. Anders Hejlsberg (ahejlsberg)
    added
    FixedA PR has been merged for this issue
    on Sep 5, 2017
  17. Anders Hejlsberg (ahejlsberg)
    closed this as completedin #18246on Sep 11, 2017
  18. microsoft
    locked and limited conversation to collaborators on Jun 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

BugA bug in TypeScriptFixedA PR has been merged for this issue

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions