Repository navigation
rest args are busted #12956
Description
Using the latest master, this seems to be a pretty serious regression. I noticed my site broke, and tracked it down to an object rest regression.
Basically this code:
let arg = {a: true, b: "test", c: 42};
let fn = ({a, ...rest}) => {
console.log(`a is: ${JSON.stringify(a)}`);
console.log(`rest is ${JSON.stringify(rest)}`);
}
fn(arg);Is generating this emit:
var __rest = (this && this.__rest) || function (s, e) {
var t = {};
for (var p in s) if (Object.prototype.hasOwnProperty.call(s, p) && !e.indexOf(p))
t[p] = s[p];
return t;
};
var arg = { a: true, b: "test", c: 42 };
var fn = function (_a) {
var a = _a.a, rest = __rest(_a, ["a"]);
console.log("a is: " + JSON.stringify(a));
console.log("rest is " + JSON.stringify(rest));
};
fn(arg);Which produces this output
a is: true
rest is {"a":true}
The issue is with !e.indexOf(p), as this only returns "true" for the property which is the first in the list (i.e. the index is 0). It should probably be e.indexOf(p) < 0.
Activity
billti commentedon Dec 15, 2016
Actually, looks like this was fixed a couple weeks back, but the LKG is out of date. I'll update that.
billti commentedon Dec 15, 2016
Updated the LKG which resolved this.