Skip to content

Design Meeting Notes, 11/30/2016 #12622

Closed

Description

__extends and static methods / accessors

var __extendStatics = (this && this.__extendStatics) ||
    Object.setPrototypeOf || 
   ({ __proto__: [] } instanceof Array && function (d, b) { d.__proto__ = b; }) || 
   function (d, b) { for (var p in b) if (b.hasOwnProperty(p)) d[p] = b[p]; };

var __extends = (this && this.__extends) || function (d, b) {
   __extendStatics(d, b);
   function __() { this.constructor = d; }
   d.prototype = b === null ? Object.create(b) : (__.prototype = b.prototype, new __());
};
  • What about the other side of the issue, emitting methods and accessors as enumrable: false?
    • we have to do it for --target ES5 and not --target ES3
    • if we do this we break the static inheritance for IE10,
    • concolusion:
      • wait on more feedback for this

Promise in lib.d.ts

Extensibility (Ryan Cavanaugh (@RyanCavanaugh))

Activity

  1. falsandtru commented on Dec 2, 2016

    @falsandtru
    Contributor

    Mohamed Hegazy (@mhegazy) Where should we give feedback for __extends?

  2. mhegazy commented on Dec 2, 2016

    @mhegazy
    ContributorAuthor

    either here or at #12488

  3. falsandtru commented on Dec 2, 2016

    @falsandtru
    Contributor

    thx

  4. pwnall commented on Dec 22, 2016

    @pwnall

    I just got hit by the PromiseLike issue in the WebCrypto API.

    The notes above seem to state that the solution will be splitting DOM definitions into multiple libraries. As an approach, I'd suggest setting up the scaffold, and splitting out one (small) API, so the community has an example PR to look at. This way, we (the community) could help with the APIs we care about.

  5. locked and limited conversation to collaborators on Jun 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Design NotesNotes from our design meetings

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions