Skip to content

chore: update tslib - #2899

Merged
Jake Bailey (jakebailey) merged 6 commits into
microsoft:v2from
Zamiell:tslib
Jul 24, 2023
Merged

Jake Bailey (jakebailey) merged 6 commits into
microsoft:v2from
Zamiell:tslib

Conversation

@Zamiell

@Zamiell James (Zamiell) commented Jul 21, 2023 •

Copy link
Copy Markdown
Contributor

this PR updates the tslib dep to latest in the package.json file and yarn.lock, which fixes yarn bootstrap failing on node 18.

the other changes are simply a result of performing the yarn bootstrap command, so I can take them out of the PR if you want.

@jakebailey

Copy link
Copy Markdown
Member

Pulled out the other ones into #2900; this is an ongoing problem, unfortunately.

@Zamiell

Copy link
Copy Markdown
Contributor Author

do you wanna rebase this on main for me? not sure what to do specifically

| "reference/Decorators.md"
| "reference/ESM Support for Node.md"
| "reference/Enums.md"
| "reference/ESM Support for Node.md"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I honestly have no idea why these files are still changed after I merged #2900. Probably best to drop them from the PR and limit this to the package.json and lockfile updates, although my impression is that even if we fix this one thing, you get an even more cryptic issue later in non-node-16 anyway so...

@jakebailey

Copy link
Copy Markdown
Member

do you wanna rebase this on main for me? not sure what to do specifically

There's no need for that; Github figures it out! other than the... other changes? No idea.

@Zamiell

Copy link
Copy Markdown
Contributor Author

ok i did some manual edits and it should be good now

@jakebailey
Jake Bailey (jakebailey) enabled auto-merge (squash) July 24, 2023 21:15
@jakebailey
Jake Bailey (jakebailey) merged commit 501e62c into microsoft:v2 Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants