Skip to content

Fix the VS version script #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Orta Therox (orta) merged 2 commits into from
Dec 5, 2019
Merged

Fix the VS version script #146

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5f22024
Fix the VS version script
orta Dec 5, 2019
4b6f5d9
Exclude betas
orta Dec 5, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 13 additions & 10 deletions scripts/updateURLs.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,13 @@ const {writeFileSync} = require("fs")

/**
* Gets the NPM package JSON for a module
* @param {string} name
* @param {string} name
*/
const getLatestNPMPackage = async (name) => {
const packageJSON = await axios({
url: `https://registry.npmjs.org/${name}`
})

return packageJSON.data
}

Expand All @@ -40,18 +40,18 @@ const getLatestVSExtensions = async () => {
'X-Requested-With': 'XMLHttpRequest',
'X-VSS-ReauthenticationAction': 'Suppress',
};

const query = (name) =>
`{"assetTypes":["Microsoft.VisualStudio.Services.Icons.Default","Microsoft.VisualStudio.Services.Icons.Branding","Microsoft.VisualStudio.Services.Icons.Small"],"filters":[{"criteria":[{"filterType":8,"value":"Microsoft.VisualStudio.Ide"},{"filterType":10,"value":"${name}"},{"filterType":12,"value":"37888"}],"direction":2,"pageSize":54,"pageNumber":1,"sortBy":0,"sortOrder":0,"pagingToken":null}],"flags":870}`


const extensionSearchResults = await axios({
url: 'https://marketplace.visualstudio.com/_apis/public/gallery/extensionquery',
method: 'POST',
headers: headers,
data: query("typescript")
})

if (!extensionSearchResults.data || !extensionSearchResults.data.results) {
throw new Error("Got a bad response from VS marketplace")
}
Expand All @@ -69,13 +69,16 @@ const go = async () => {

console.log(`Grabbing the VS TypeScript extension for ${latest} from the marketplace`)
const extensions = await getLatestVSExtensions()
const currentExtension = extensions.find(e => e.versions[0].version === latest)

console.log(`Found ${extensions.length} extensions`)

const sortedByVersion = extensions.sort((l, r) => r.versions[0].version.localeCompare(l.versions[0].version)).filter(e => !e.extensionName.toLowerCase().includes("beta"))
console.log(`Looking at ${sortedByVersion.map(e => e.versions[0].version).join(", ")}`)

// @ts-ignore
const currentURLs = require("../src/_data/urls")
if (currentExtension) {
const extensionURL = `https://marketplace.visualstudio.com/items?itemName=TypeScriptTeam.${currentExtension.extensionName}`

if (sortedByVersion[0]) {
const extensionURL = `https://marketplace.visualstudio.com/items?itemName=TypeScriptTeam.${sortedByVersion[0].extensionName}`
currentURLs.vs2017_download = extensionURL
currentURLs.vs2019_download = extensionURL
}
Expand Down
6 changes: 3 additions & 3 deletions src/_data/urls.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"vs2017_download": "https://marketplace.visualstudio.com/items?itemName=TypeScriptTeam.typescript-364",
"vs2019_download": "https://marketplace.visualstudio.com/items?itemName=TypeScriptTeam.typescript-364",
"vs2017_download": "https://marketplace.visualstudio.com/items?itemName=TypeScriptTeam.typescript-372",
"vs2019_download": "https://marketplace.visualstudio.com/items?itemName=TypeScriptTeam.typescript-372",
"vscode_download": "https://code.visualstudio.com",
"sublime_ts_download": "https://github.com/Microsoft/TypeScript-Sublime-Plugin",
"atom_ts_download": "https://atom.io/packages/atom-typescript",
Expand All @@ -19,4 +19,4 @@
"ts_twitter": "https://twitter.com/typescript/",
"ts_twitter_search": "https://twitter.com/search?q=%23typescript",
"landing_page_video": "http://video.ch9.ms/ch9/4ae3/062c336d-9cf0-498f-ae9a-582b87954ae3/B881_mid.mp4"
}
}