Skip to content

Change readyState from string to DocumentReadyState #404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mohamed Hegazy (mhegazy) merged 1 commit into from
Apr 4, 2018
Merged

Change readyState from string to DocumentReadyState #404

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion baselines/dom.generated.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3972,7 +3972,7 @@ interface Document extends Node, GlobalEventHandlers, ParentNode, DocumentEvent
/**
* Retrieves a value that indicates the current state of the object.
*/
readonly readyState: string;
readonly readyState: DocumentReadyState;
/**
* Gets the URL of the location that referred the user to the current page.
*/
Expand Down Expand Up @@ -15983,6 +15983,7 @@ type ChannelCountMode = "max" | "clamped-max" | "explicit";
type ChannelInterpretation = "speakers" | "discrete";
type DisplayCaptureSurfaceType = "monitor" | "window" | "application" | "browser";
type DistanceModelType = "linear" | "inverse" | "exponential";
type DocumentReadyState = "loading" | "interactive" | "complete";
type EndOfStreamError = "network" | "decode";
type ExpandGranularity = "character" | "word" | "sentence" | "textedit";
type GamepadHand = "" | "left" | "right";
Expand Down
16 changes: 15 additions & 1 deletion inputfiles/overridingTypes.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,17 @@
"interface": {}
},
"enums": {
"enum": {}
"enum": {
"DocumentReadyState": {
"specs": "dom4",
"value": [
"loading",
"interactive",
"complete"
],
"name": "DocumentReadyState"
}
}
},
"interfaces": {
"interface": {
Expand Down Expand Up @@ -315,6 +325,10 @@
},
"properties": {
"property": {
"readyState": {
"name": "readyState",
"override-type": "DocumentReadyState"
},
"documentElement": {
"name": "documentElement",
"override-type": "HTMLElement"
Expand Down