[falsandtru (falsandtru)]

http://www.w3.org/TR/IndexedDB/#database-interface

[Microsoft Contribution License Agreements (msftclas)]

Hi falsandtru (@falsandtru), I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

[falsandtru (falsandtru)]

ouch

[Microsoft Contribution License Agreements (msftclas)]

falsandtru (@falsandtru), Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.

Thanks, MSBOT;

[Deleted user (ghost)]

Is there any issue tracking this in TypeScript repo? A link to it would be nice.
This PR needs to be squashed to a single commit for multiple reasons. So:

cd TSJS-lib-generator
git rebase -i HEAD~4
# editor will open
# replace `pick` with `f`, for all lines except the first one, save and close the editor
git push -f

[falsandtru (falsandtru)]

I didn't report this issue in TypeScript repo.

[Mohamed Hegazy (mhegazy)]

falsandtru (@falsandtru) thanks for the PR, two comments:

1. please file an issue on the TS repo, this will allow for documenting the change.
2. do not change the webidl file directly, this file is external. put your changes in https://github.com/Microsoft/TSJS-lib-generator/blob/master/inputfiles/overridingTypes.json instead.

[falsandtru (falsandtru)]

All right, I'll fix it. And now, is there a way to fix webidl files?

[Mohamed Hegazy (mhegazy)]

The webidl files are external. we grab them periodically from the IE/Edge team. files inputfiles/addedTypes.json, inputfiles/overridingTypes.json, and inputfiles/removedTypes.json allow to augment the webidl definitions to get the desired shape. this way when a new version of the webidl is picked up the augmentations are not lost.

See Readme.md for more information.

[falsandtru (falsandtru)]

I understood that. Thanks.

[falsandtru (falsandtru)]

Mohamed Hegazy (@mhegazy) I filed a new issue: microsoft/TypeScript#6408, and I fixed your specified points. Please review, Mohamed Hegazy (@mhegazy) Zhengbo Li (@zhengbli) .

[falsandtru (falsandtru)]

I have some unpublished fixes. I want to send that fixes after accepting this commit.

[Mohamed Hegazy (mhegazy)]

👍

[Zhengbo Li (zhengbli)]

falsandtru (@falsandtru) Thank you for contributing!