[susiwen8 (susiwen8)]

• close missing: transaction durability in indexeddb TypeScript#48601
• close webworker: waitUntil should require a Promise TypeScript#48553

[github-actions]

Thanks for the PR!

This section of the codebase is owned by Kagami Sascha Rosylight (@saschanaz) - if they write a comment saying "LGTM" then it will be merged.

[Holger Jeromin (HolgerJeromin)]

Thanks for helping.
You manipulated a generated file.
The correct place would be overridingTypes.jsonc

[susiwen8 (susiwen8)]

Thanks for helping. You manipulated a generated file. The correct place would be overridingTypes.jsonc

Thanks!

[Kagami Sascha Rosylight (saschanaz)]

There is a reason that ExtendableEvent.waitUntil accepts any: It basically accept any object and wraps it with Promise.resolve() if it's not a promise.

But strictly requiring a promise seems to make a sense in this case.

[susiwen8 (susiwen8)]

There is a reason that ExtendableEvent.waitUntil accepts any: It basically accept any object and wraps it with Promise.resolve() if it's not a promise.

But strictly requiring a promise seems to make a sense in this case.

Yes, I saw you commit 3 years ago.
I read doc in MDN. Telling that waitUntil accept a promise.

[Kagami Sascha Rosylight (saschanaz)]

Whenever MDN says a promise as a parameter it means anything. I'll file a bug there.

[susiwen8 (susiwen8)]

So I should change waitUntil back?

[Kagami Sascha Rosylight (saschanaz)]

You can keep it, but you need to follow what Holger Jeromin (@HolgerJeromin) said to fix the test failure: #1326 (comment)

[susiwen8 (susiwen8)]

Kagami Sascha Rosylight (@saschanaz) Tests passed. Please take a look.

[Kagami Sascha Rosylight (saschanaz)]

It's still running 😉 (Please don't ping for test results, I'll look when I can.)

[Kagami Sascha Rosylight (saschanaz)]

lgtm

(Checking if this repo supports automerge)

(Oops, it finished right after this comment.)

[github-actions]

Merging because Kagami Sascha Rosylight (@saschanaz) is a code-owner of all the changes - thanks!