You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fit_fast default model_type appears to contain a typo ("restrospective" vs "retrospective") #57
Because of this, calling fit_fast(...) without explicitly passing model_type seems to use "restrospective" (with typo), which does not match "retrospective" in the downstream conditionals.
This appears to change the behavior materially. In my case:
From reading the code, it looks like the default typo causes execution to fall through to the else branch instead of the intended "retrospective" branch.
There may also be another typo here:
elifmodel_type=="prospective-restricted:":
with a trailing : inside the string.
So I think there are possibly two string-matching issues:
"restrospective" instead of "retrospective" in the default argument
"prospective-restricted:" instead of "prospective-restricted"
Expected behavior:
the default model_type should likely be "retrospective"
calling fit_fast(...) with no explicit model_type should behave the same as fit_fast(..., model_type="retrospective")
Activity