Repository navigation
Add opt-in single-node multi-tenant SPANN with pluggable postings - #475
Draft
Baotong Lu (baotonglu) wants to merge 1 commit into
Conversation
Add tenant-isolated shared posting backends, recovery/state, automatic checkpoints, server/client APIs, offline administration and a runnable quick start. Include FILEIO/TiKV support and TiKV deadline repair; exclude unrelated generic tuning. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Baotong Lu (@baotonglu) please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add opt-in, single-node multi-tenant SPANN with tenant-isolated indexes, shared
posting storage, node-owned RocksDB recovery/state, checkpoint/replay, and
epoch-protected residency/eviction.
plus offline
tenanttooladministration and reproducible workload harnesses.request-buffer/completion ownership.
and configuration/recovery design.
MULTITENANTdefaults toOFF; enabling it automatically enables the RocksDBbuild dependency even for FILEIO/TiKV postings. TiKV remains separately optional.
Client-only builds can address a remote tenant-enabled server without a local manager.
Automatic checkpoints default to 1 GiB of retained recovery-record key/value bytes,
a 300-second minimum interval, and a 4 GiB pressure trigger that bypasses the
cooldown and holds new insert/delete admission. Covered logs are deleted only
after checkpoint publication; failures fence the node and wake waiting writers.
A directly coupled native STATIC save/reload null-checkpoint dereference is also
fixed. Optional generic heap/worker/buffer tuning and large benchmark artifacts
are deliberately excluded.
Validation
MULTITENANT=ON,TIKV=ON: real RocksDB/FILEIO/TiKV tenant/backend suiteMULTITENANT=ON,TIKV=OFF: selected local suiteFeature-OFF builds were checked both with and without RocksDB. Live TiKV tests
used a dedicated temporary cluster; owned processes and temporary data were retired.
Known limitations / review notes
ConcurrentHashMapTestcaseswith
FOLLY=OFF, TBB=ON: overwrite return values, iterator snapshots after clear,and concurrent conditional updates. The same failures were independently
reproduced using only the unmodified upstream header/tests. They are not fixed
or suppressed here; this PR does not claim the complete baseline suite or CI is green.
Already-admitted writes can overshoot; SST/WAL overhead and snapshots require
separate disk monitoring/headroom. No forced full compaction is added.
TiKV provides distributed posting storage, not distributed tenant ownership or failover.
has not been validated.
Historical RocksDB layout diagnostics are documented without presenting their
numbers as measurements of this revision.
Prepared against
users/qiazh/pre-merge-tikv-bugfixat3cf47fdfc4995a254b17c12657bdd7c0abdc7396.