Skip to content

Update git clone command to include ThirdParty submodules - #326

Merged
MaggieQi merged 2 commits into
microsoft:mainfrom
phgn0:main
Jul 29, 2022
Merged

MaggieQi merged 2 commits into
microsoft:mainfrom
phgn0:main

Conversation

@phgn0

Copy link
Copy Markdown
Contributor

cmake throws an error if the ThirdParty/zstd/build/cmake git submodule is not cloned before the build:

CMake Error at CMakeLists.txt:96 (add_subdirectory):
add_subdirectory given source "ThirdParty/zstd/build/cmake" which is not an
existing directory.

So update the install command to avoid more users running into this.

See #320

`cmake` throws an error if the `ThirdParty/zstd/build/cmake` git submodule is not cloned before the build:
```
CMake Error at CMakeLists.txt:96 (add_subdirectory):
add_subdirectory given source "ThirdParty/zstd/build/cmake" which is not an
existing directory.
```

So update the install command to avoid more users running into this.

See microsoft#320
@MaggieQi
MaggieQi merged commit a192a17 into microsoft:main Jul 29, 2022
L1ray (L1-ray) pushed a commit to L1-ray/SPTAG that referenced this pull request May 9, 2026
)

`cmake` throws an error if the `ThirdParty/zstd/build/cmake` git submodule is not cloned before the build:
```
CMake Error at CMakeLists.txt:96 (add_subdirectory):
add_subdirectory given source "ThirdParty/zstd/build/cmake" which is not an
existing directory.
```

So update the install command to avoid more users running into this.

See microsoft#320

Co-authored-by: MaggieQi <chenqi871025@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants