Repository navigation
Support gif, bmp, pdf and Excel resource uploads - #454
Merged
Petebro-MSFT (Petebro-MSFT) merged 6 commits intoOct 27, 2026
Merged
Petebro-MSFT (Petebro-MSFT) merged 6 commits into
Petebro-MSFT (Petebro-MSFT) merged 6 commits into
Conversation
Co-authored-by: Cláudio Silva <19521315+ClaudioESSilva@users.noreply.github.com> Co-authored-by: bdevries <18584187+Branden-DeVries@users.noreply.github.com> Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: f2cc77f6-40eb-41b5-ad08-df3c6b762d3f
Co-authored-by: Cláudio Silva <19521315+ClaudioESSilva@users.noreply.github.com> Co-authored-by: bdevries <18584187+Branden-DeVries@users.noreply.github.com> Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: f2cc77f6-40eb-41b5-ad08-df3c6b762d3f
Co-authored-by: Cláudio Silva <19521315+ClaudioESSilva@users.noreply.github.com> Co-authored-by: bdevries <18584187+Branden-DeVries@users.noreply.github.com> Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: f2cc77f6-40eb-41b5-ad08-df3c6b762d3f
Co-authored-by: Cláudio Silva <19521315+ClaudioESSilva@users.noreply.github.com> Co-authored-by: bdevries <18584187+Branden-DeVries@users.noreply.github.com> Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: f2cc77f6-40eb-41b5-ad08-df3c6b762d3f
Co-authored-by: Cláudio Silva <19521315+ClaudioESSilva@users.noreply.github.com> Co-authored-by: bdevries <18584187+Branden-DeVries@users.noreply.github.com> Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: f2cc77f6-40eb-41b5-ad08-df3c6b762d3f
Co-authored-by: Cláudio Silva <19521315+ClaudioESSilva@users.noreply.github.com> Co-authored-by: bdevries <18584187+Branden-DeVries@users.noreply.github.com> Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: f2cc77f6-40eb-41b5-ad08-df3c6b762d3f
Petebro-MSFT (Petebro-MSFT)
marked this pull request as ready for review
October 27, 2026 19:09
Petebro-MSFT (Petebro-MSFT)
marked this pull request as draft
October 27, 2026 19:11
Petebro-MSFT (Petebro-MSFT)
marked this pull request as ready for review
October 27, 2026 19:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #233 and incorporates #215. Thanks Cláudio Silva (@ClaudioESSilva) and bdevries (@Branden-DeVries); both are credited as co-authors.
Changes
Write-RsCatalogItemuploads.gif,.bmp,.pdf,.xlsand.xlsxas resources with explicit MIME types.Write-RsFolderContentuploads.gif,.bmpand.pdf. It still skips Excel files, because the default server upload allowlist rejects.xls/.xlsxand failing a whole folder upload would be a regression..xlsusesapplication/vnd.ms-excel(not the XLSX type),.jpgstaysimage/jpeg, and the resource error message is kept.appveyor.ymladds*.xlstoAllowedResourceExtensionsForUpload(this caused the Support gif, bmp, xls, xlsx and pdf @ Write-RSFolderContent & Write-RsCatalogItem #233 CI failure).Tests/Unit/CatalogItemResourceUpload.Tests.ps1.Notes
.pdfresources asapplication/octet-streamregardless of the MIME type sent, so the PDF test accepts either value..xlsmis not included; it could be a follow-up.Validation
image/gif/image/bmp; folder upload skips xlsx.