Repository navigation
[BREAKING] MAINT: Simplify scenario construction and initializer parameters - #3404
Merged
Richard Lundeen (richlundeen) merged 6 commits intoOct 21, 2026
Conversation
…meters Unify initializer declarations and typed parameter resolution, separate configuration from validation, and handle required inputs without blocking metadata. Reject fractional integer coercion, route construction through ScenarioContext, reuse registry configuration for estimates, and avoid duplicate resume reads. Update author guides and focused regression coverage. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 11462efb-198b-4fa6-869c-2be302f88fa6
Separate registration, clearing/default restoration, and saved-name registration into independent desktop and mobile tests. Preserve assertions and the 30-second budget, wait for runtime readiness and saved preferences before reloads, and seed complete preferences in the isolated restored-name case. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 11462efb-198b-4fa6-869c-2be302f88fa6
Keep the split operation acceptance flows together with upstream runtime-readiness and preference-persistence assertions. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 11462efb-198b-4fa6-869c-2be302f88fa6
varunj-msft
approved these changes
Oct 21, 2026
Richard Lundeen (richlundeen)
enabled auto-merge
October 21, 2026 19:25
Keep the scenario and initializer changes current with the approved main branch. The merge is conflict-free. Preserve typed parameter resolution and the split browser acceptance flows. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 11462efb-198b-4fa6-869c-2be302f88fa6
Integrate the latest main changes to keep the approved PR eligible under strict up-to-date branch protection. Preserve the existing scenario simplification and browser test fixes. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 11462efb-198b-4fa6-869c-2be302f88fa6
Preserve main's faster initial preference seeding and explicit state checks, together with the PR's runtime-readiness waits. Retain upstream Pillow and Ruff updates. Local validation passed 1,861 scoped Python tests and all six changed browser preference cases; the full pre-commit command was attempted twice but the configured package index cannot provide the upstream Ruff 0.17.1 pin. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 11462efb-198b-4fa6-869c-2be302f88fa6
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 21, 2026
Richard Lundeen (richlundeen)
deleted the
richlundeen-phase-g-relevance
branch
October 21, 2026 22:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Complete the remaining simplifications from the Simplifying Scenarios plan, following #2132. The two historical adaptive bugs were already fixed in #2152; this PR preserves their regression coverage rather than introducing another fix. The biggest change is to modify initializer paramaters to match other registries like scenarios and converters/targets/etc.
Here is a list of changes:
days: 0.5ordays: -0.5cannot becomedays: 0and trigger unconditional dataset refresh.ScenarioContext, including nested manual builders and per-technique converters. Copy converter containers while retaining live converter instances by identity. Keep scenario-specific scorers and options on the scenario.Breaking change and migration: custom initializers must change
supported_parametersfrom an instance property to a classmethod, declare parameter types, and read typed scalar values rather than indexing string lists. Useset_params_from_argsto configure inputs instead of assigning raw or partial parameter dictionaries.validate_params()checks resolved values without coercing or repairing them. CLI/YAML syntax is unchanged. Fractional values supplied for integer parameters now raise an error rather than truncate. These changes remove separate parsing and configuration mechanisms; no generic builder framework, new dependency, lockfile change, or persistence migration is included.