Repository navigation
FIX: Include word selection strategy in RandomTranslationConverter identifier - #3371
Open
Manohar Paturi (ManoharPaturi) wants to merge 4 commits into
Open
Manohar Paturi (ManoharPaturi) wants to merge 4 commits into
Manohar Paturi (ManoharPaturi) wants to merge 4 commits into
Conversation
…entifier Signed-off-by: Manohar Paturi <186662190+ManoharPaturi@users.noreply.github.com>
Roman Lutz (romanlutz)
approved these changes
Oct 20, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 20, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 20, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3370
RandomTranslationConverter inherits from both LLMGenericTextConverter and WordLevelConverter, but its _build_identifier method previously called only super()._build_identifier(). That resolved to LLMGenericTextConverter and bypassed WordLevelConverter._build_identifier(), leaving word_selection_strategy, word_selection_strategy_params, and word_split_separator absent from the identifier parameters. This change explicitly merges identifier parameters from both base classes so that converters configured with distinct selection strategies produce distinct identifiers.
Tests and Documentation
Added unit tests in test_random_translation_converter.py verifying that word selection strategy and strategy parameters appear in the identifier parameters, and that converters with different strategies produce distinct identifier hashes.
No documentation change needed, so I did not run JupyText.