Repository navigation
FIX MOSSBench and VLSU SQLite isolation collisions (#2775) - #2781
Merged
Roman Lutz (romanlutz) merged 1 commit intoSep 23, 2026
Merged
Roman Lutz (romanlutz) merged 1 commit into
Roman Lutz (romanlutz) merged 1 commit into
Conversation
5 tasks
Roman Lutz (romanlutz)
approved these changes
Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2775.
The
TestMossBenchDatasetandTestVLSUMultimodalDatasetclasses previously relied on their own customsetup_memoryfixtures which explicitly constructed default, file-backedSQLiteMemory()instances. This bypassed the isolatedsqlite_instancefixture introduced in PR #2640, leading toOperationalErrorduring concurrent test execution when multiple workers attempted to apply schema migrations to the same default database file.This PR removes the custom memory setup routines and natively adopts the isolated
sqlite_instancefixture for both dataset tests, guaranteeing isolated in-memory databases and scoped temporary results paths.Note: While the exact original remote collision mechanism in #2775 remains unproven, this fix deterministically removes the precondition (shared file-backed memory) that enabled the collision.
Tests and Documentation
setup_memoryintest_mossbench_dataset.pyandtest_vlsu_multimodal_dataset.pywith@pytest.mark.usefixtures("sqlite_instance").test_dataset_uses_isolated_memory_and_results_path) to both classes to formally prove that tests now run against:memory:and use an absolute, non-default temporary path for results.make unit-testpasses on 4 workers cleanly without SQLite collisions.JupyText execution was not required for this PR as changes are strictly limited to internal unit test fixtures and do not affect public APIs or documentation.