Repository navigation
Issue #1228 path as reference to external - #1246
Merged
Vincent Biret (baywet) merged 4 commits intoJun 13, 2023
Merged
Vincent Biret (baywet) merged 4 commits into
Vincent Biret (baywet) merged 4 commits into
Conversation
added 2 commits
May 15, 2023 21:58
Elize VDR (elize-vdr)
requested review from
Maggie Kimani (MaggieKimani1),
Andrew Omondi (andrueastman),
Vincent Biret (baywet),
Darrel (darrelmiller),
Irvine Sunday (irvinesunday),
Millicent Achieng (millicentachieng),
Peter Ombwa (peombwa) and
Mustafa Zengin (zengin)
as code owners
May 15, 2023 20:27
Vincent Biret (baywet)
requested changes
May 16, 2023
Vincent Biret (baywet)
left a comment
Vincent Biret (baywet)
left a comment
Member
There was a problem hiding this comment.
Thanks for the contribution. A couple of comments to help wrap it up.
Vincent Biret (baywet)
approved these changes
Jun 9, 2023
Member
There was a problem hiding this comment.
Thanks for making the changes. Maggie Kimani (@MaggieKimani1) or Millicent Achieng (@millicentachieng) for final review and merge.
Maggie Kimani (MaggieKimani1)
approved these changes
Jun 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Took a stab at implementing the case where tha path is an external reference, see issue #1228.