Repository navigation
fix(hidi): refresh container base images during publishing - #934
Open
Treicy Sanchez (Treicysg) wants to merge 5 commits into
Open
Treicy Sanchez (Treicysg) wants to merge 5 commits into
Treicy Sanchez (Treicysg) wants to merge 5 commits into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Treicy Sanchez (Treicysg)
marked this pull request as draft
November 4, 2026 19:47
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Treicy Sanchez (Treicysg)
changed the title
Treicy Sanchez (Treicysg)
marked this pull request as ready for review
November 4, 2026 20:59
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
| --tag "msgraphprodregistry.azurecr.io/public/openapi/hidi:$(HidiReleaseVersion)" ` | ||
| --tag "msgraphprodregistry.azurecr.io/public/openapi/hidi:latest" ` | ||
| --push . | ||
| docker buildx build --pull --platform linux/amd64,linux/arm64/v8 --secret "id=nuget_config,src=$nugetConfigPath" --tag "msgraphprodregistry.azurecr.io/public/openapi/hidi:$(HidiReleaseVersion)" --tag "msgraphprodregistry.azurecr.io/public/openapi/hidi:latest" --push . |
Contributor
There was a problem hiding this comment.
can we please retain the multi-line style?
The run-on line is a pain to parse in an editor, yeah, I still like things to be human readable
Author
There was a problem hiding this comment.
Should we mark SonarCloud warnings as false positives? or use multi-line argument arrays?
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull current base images when building Hidi containers.