Skip to content

Missing paths on derived/odata cast paths #323

Closed

Description

The issue #302 was raised to fix missing paths like microsoftgraph/msgraph-metadata#179 and microsoftgraph/msgraph-beta-sdk-dotnet#338.

However, after some validation, Peter Ombwa (@peombwa) confirmed that the new implementation when setting ExpandDerivedTypesNavigationProperties to true is generating many invalid/unsupported paths.

Is there a better way to identify which paths should be generated? Should we have a custom annotation so API owners could add it in the API description?

Related to #268

Activity

  1. added
    priority:p0Blocking issue/ loss of critical functions. An ICM may be filed to communicate urgency. SLA<=48hrs
    priority:p2Medium. Generally has a work-around and a smaller sub-set of customers is affected. SLA <=30 days
    and removed
    priority:p0Blocking issue/ loss of critical functions. An ICM may be filed to communicate urgency. SLA<=48hrs
    on Jan 24, 2023
  2. irvinesunday commented on Apr 26, 2023

    @irvinesunday
    Contributor

    One way of fixing the invalid paths here will involve implementing the new annotations on actions/functions: https://issues.oasis-open.org/browse/ODATA-1538#

    • Org.OData.Core.V1.ExplicitOperationBindings
    • Org.OData.Core.V1.RequiresExplicitBinding

    These will help control the generation of operations bound to the derived/OData type cast segments.
    This will also help resolve: #232

  3. maisarissi commented on Apr 27, 2023

    @maisarissi
    Author
  4. sebastienlevert commented on Apr 27, 2023

    @sebastienlevert

    Now that the spec seems applied, it feels like the right path. I don't have the context but it seems to me to be the way forward. What is the broader impact?

  5. irvinesunday commented on Apr 28, 2023

    @irvinesunday
    Contributor

    Now that the spec seems applied, it feels like the right path. I don't have the context but it seems to me to be the way forward. What is the broader impact?

    I have provided more details here regarding use and impact: #378 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

priority:p2Medium. Generally has a work-around and a smaller sub-set of customers is affected. SLA <=30 daysstatus:needs-discussionAn issue that requires more discussion internally before resolvingtype:featuretype:regressionA bug from previous release

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions