Feedback around setting up MSBuildForUnity in your own project #74

Activity

1. chrisfromwork commented on Dec 6, 2019

   

   C. M. Barth (chrisfromwork)

   on Dec 6, 2019

   ContributorAuthor

   More actions

   adding the scope registries stub above dependencies in manifest.json did not seem to result in the msbuildforunity package appearing in the unity package manager or the msbuild dropdown in the unity toolbar
2. C. M. Barth (chrisfromwork)

   changed the title [-]It's unclear how to add MSBuildForUnity to your own project[/-] [+]Feedback around setting up MSBuildForUnity in your own project[/+] on Dec 6, 2019
3. chrisfromwork commented on Dec 6, 2019

   

   C. M. Barth (chrisfromwork)

   on Dec 6, 2019

   Last edited by chrisfromwork

   ContributorAuthor

   More actions

   file referencing the package in a submodule location seems to work.

   Turning on auto generation seems to generate an error if you don't run Regenerate C# SDK Projects

   DirectoryNotFoundException: Could not find a part of the path "E:\chrisfromwork\MixedReality-SpectatorView-2\src\SpectatorView.Unity\MSBuild\settings.json".
4. andreiborodin commented on Dec 9, 2019

   

   Andrei Borodin (andreiborodin)

   on Dec 9, 2019

   Contributor

   More actions

   Great feedback, thanks for looking in, questions:

   • Did you start with Quick Start
   • Or did you look at the release
5. Andrei Borodin (andreiborodin)

   self-assigned this

   on Dec 9, 2019
6. Andrei Borodin (andreiborodin)

   added

   documentationImprovements or additions to documentationImprovements or additions to documentation

   on Dec 9, 2019
7. Andrei Borodin (andreiborodin)

   added this to the 0.9.0 Release milestone on Dec 9, 2019
8. chrisfromwork commented on Dec 11, 2019

   

   C. M. Barth (chrisfromwork)

   on Dec 11, 2019

   Last edited by andreiborodin

   ContributorAuthor

   More actions

   I started with quick start. Other comments:

   1. It would be nice to show the entire manifest.json file in the "Quick Start" the stubs provided may be enough information for folks that know what they are doing, but if you have never opened a manifest.json file, you may not fully understand where to place the text stubs provided. Showing the whole file with the added lines bolded or an abreviation of the file where folks have some sort of reference point for where they are placing the content could help.

   2. Documentation should call out that all code created for consumption should be placed in an asmdef. Trying to reference an Assembly-CSharp project from another Assembly-CSharp project generates issues. Moved to #123.

   3. When on asmdefs exist, its unclear whether to declare external dependencies in Assembly-CSharp vs the Dependencies project. We should pick a best practice compared to trying to support a wide variety of permutations. It was also unclear how to rebuild these/what building was required to get dlls generated in your local project.

   4. It seemed that project references needed to be duplicated in both the asmdef you care about's project as well as the Dependencies project when making references to other unity projects. Moved to #123
9. andreiborodin commented on Jan 31, 2020

   

   Andrei Borodin (andreiborodin)

   on Jan 31, 2020

   Last edited by andreiborodin

   Contributor

   More actions

   2 and 4 only applies to cross-unity project dependencies.