You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
SearchDiagnostics/CollectionDbSearchDiagnostics.ps1 log dir is created inside sql script folder #35
Hi.
This is not a bug, but a simple fix to make CollectionDBSearchDiagnostics.ps1 behave like ConfigurationDBSearchDiagnostics.ps1
The first script creates the log folder inside the SQL scripts folder instead of creating it in the root, as the second script does.
David J. Quiroga (@sqdavid) The bug actually is the usage of $PWD instead of $PSScriptRoot. If this is fixed, the log folder will always be created in the SearchDiagnostics folder. There are a lot of places in our scripts where this bug is present. We would love for you to send a PR.
Activity
bittusarkar commentedon Apr 24, 2019
David J. Quiroga (@sqdavid) The bug actually is the usage of
$PWDinstead of$PSScriptRoot. If this is fixed, the log folder will always be created in theSearchDiagnosticsfolder. There are a lot of places in our scripts where this bug is present. We would love for you to send a PR.