Skip to content

SearchDiagnostics/CollectionDbSearchDiagnostics.ps1 log dir is created inside sql script folder #35

Open

Description

Hi.
This is not a bug, but a simple fix to make CollectionDBSearchDiagnostics.ps1 behave like ConfigurationDBSearchDiagnostics.ps1
The first script creates the log folder inside the SQL scripts folder instead of creating it in the root, as the second script does.

https://github.com/Microsoft/Code-Search/blob/3be409ea44ce2a58e5936f6534b4273b0d5b51e4/SearchDiagonistics/CollectionDBSearchDiagnostics.ps1#L20

If the sugestion is accepted and you are busy I could make a PR, since it is quite simple.

Regards

Activity

  1. bittusarkar commented on Apr 24, 2019

    @bittusarkar
    Contributor

    David J. Quiroga (@sqdavid) The bug actually is the usage of $PWD instead of $PSScriptRoot. If this is fixed, the log folder will always be created in the SearchDiagnostics folder. There are a lot of places in our scripts where this bug is present. We would love for you to send a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions