ADO_Server_Diagnostics_2025 cannot be run as published: missing Common.psm1 and two analyzers incompatible with Elasticsearch 8 #123

ADO_Server_Diagnostics_2025/Common.psm1 is missing from the repository. The scripts in the root of that folder import it and fail. We had to copy the file from Azure_DevOps_Server_2022.

ADO_Server_Diagnostics_2025/Troubleshooting/Utils/Common.psm1 is also missing. The Utils folder in that path contains only Algorithms.ps1, while the 2022 equivalent contains both files. Repair-Search.ps1 cannot start without it.

Analyzers/Test-ElasticsearchHealth.psm1 crashes on Elasticsearch 8. Line 109 throws IndexOutOfRangeException. The aggregation built earlier in the function groups by the _type field, which was removed in Elasticsearch 8, so mappings.buckets comes back empty and $mappings[0] is out of bounds. Azure DevOps Server 25H2 installs Elasticsearch 8.14.1, so this analyzer can never complete on a supported 25H2 deployment.

Analyzers/Test-IndicesHaveUnsupportedMappings.psm1 throws on Elasticsearch 8. Line 78 raises GET _mapping/<type> failed with status code [400] unexpectedly. The _mapping/{type} endpoint was removed in Elasticsearch 8 and now returns HTTP 400 (no handler found for uri) instead of the HTTP 404 the script expects. Suggested fix: treat 400 the same as 404, or skip this analyzer entirely on Elasticsearch 8, since the function's own comment notes there is only one mapping per index in current releases.

Because analyzers 3 and 4 run in the middle of the sequence, their exceptions abort Repair-Search.ps1 before the remaining analyzers execute. We had to patch both files locally to get a complete run.

Troubleshooting/readme.txt documents parameter names that do not exist. The actual parameters of Repair-Search.ps1 are -SQLServerInstance, -ConfigurationDatabaseName, -CollectionDatabaseName, -CollectionName, -ElasticsearchServiceUrl, -ElasticsearchServiceCredential and -EntityType.

Invoke-Sqlcmd calls fail against SQL Server instances without a trusted TLS certificate. Version 22.x of the SqlServer PowerShell module encrypts connections by default, so every call fails with The certificate chain was issued by an authority that is not trusted. Setting $PSDefaultParameterValues in the caller's session does not help, because the calls are made from inside the module scope. We had to add -TrustServerCertificate to every Invoke-Sqlcmd call in the scripts.