Repository navigation
knowledge: improve review precision from BCApps PR 12152-neg-pr12152-20261020 feedback - #248
Wenjie Fan (gggdttt) wants to merge 1 commit into
Conversation
…20261020 feedback
|
The distinction between removing a redundant explicit attribute and requiring In Could you make the intended isolation/cleanup precondition visible in the prepared case, or use a non-writing example for the no-attribute clarification? If this is deliberately an incomplete-context abstention control, please distinguish that purpose from demonstrating runtime cleanup. Keep redundant-attribute removal separate from a remedy for independently established database pollution. No AL runtime failure or model-scored regression was reproduced, and no formal draft review or readiness change has been made. |
|
Closing this unvalidated generated candidate to keep the active review backlog focused. The recorded offline evaluation reported remaining unexpected or missed findings, so this candidate has not met the acceptance criteria. This does not establish that every proposed knowledge change is incorrect or that the original feedback is resolved. The candidate and source feedback remain available here for future investigation. |
Summary
Improves BCQuality knowledge based on maintainer thumbs-down feedback from explicit BCApps PR review runs.
Source feedback
Validation
Generated by the BC-ALAgentsInternal self-improvement workflow.
Offline evaluation: regression
Candidate correctness failed: unexpected or missed findings remain. Existing ignored gold comments retain their neutral scoring semantics.
Preparation attempt 1: validated.
Selection: new. New:
synthetic__testing-transactionmodel-not-required-01. Reused (complete payloads): ``.synthetic__testing-transactionmodel-not-required-01/false_positive_guard/ [MCP] Clear environment description after environment copy BCApps#12152 (comment): Thumbs-down feedback plus the maintainer reply rejecting TransactionModel usage altogether (property should be removed from the product) show the AutoCommit->AutoRollback suggestion was wrong in substance, not just severity; the accepted fix deleted the attribute instead. No expected or ignored comment exists for this target in the dataset, so a guard expecting no finding on the TransactionModel line is faithful without inventing a clean precondition.Coverage references and outcome shapes are validated mechanically. Semantic equivalence, severity calibration and recommendation quality are NOT proved by these checks or a matching F1.
Common engine code:
ecf8e31759d6ddd6d78e3a0b7836b40134368009; dataset SHA256:8A36A70E92D9C5D6ADB179F4BB39A29409B116ACE8CB29764A4DF2E3E2DF9383.Model:
gpt-5.6-luna; judge:gpt-5.3-codex. Exact D:synthetic__testing-transactionmodel-not-required-01.Dataset base:
7c98b750c200d88ed0a81daaea5e71184a3af01b; candidate:3b3dfd9de5459cb4fc2f71285a4b6681249f8169.f4ee822aa76bed8d018029d2a6d3deb7db59a53079439b9347c5e3d8d6b3b681dad25d23fb64ac03ce45c5abd9a35d5dbd48f51f6b5a10a418c7f70dfb05910bc418a431dc0579cfea243728d3d76eaf6aebeecf0606079cdc2ea30b2031a78ee09b2644920291ddfa352f43ec90e7539c0bf3c645afadbbBaseline
Run: https://github.com/microsoft/BC-Bench/actions/runs/39436917453; conclusion: success; wall clock: 7.4 minutes.
Raw findings and runtime pin proofs are retained in the self-improvement-feedback artifact and the linked evaluation run.
synthetic__testing-transactionmodel-not-required-01Observed AI credits: unavailable; coverage 0/1 entries. Missing entries are not extrapolated into a total; reported amounts do not attest full credit coverage.
Candidate
Run: https://github.com/microsoft/BC-Bench/actions/runs/39438081729; conclusion: success; wall clock: 6.8 minutes.
Raw findings and runtime pin proofs are retained in the self-improvement-feedback artifact and the linked evaluation run.
synthetic__testing-transactionmodel-not-required-01Observed AI credits: unavailable; coverage 0/1 entries. Missing entries are not extrapolated into a total; reported amounts do not attest full credit coverage.
Missing telemetry is unavailable, not zero. Evaluation-only metrics exclude candidate generation and are not the full-cycle cost.
Human review must verify source-patch fidelity, gold correctness, and target attribution. No automatic merge or branch-protection claim is made.
Cycle usage and elapsed time (running, as of 2026-10-20T14:26:14.3049835+00:00)
Orchestrator work: 1186.404 seconds. This is not the completed GitHub workflow duration.
Subtotals are CLI/Bench-reported usage, not invoices. Missing values are not zero. Emitted-span coverage does not prove complete child/background billing; judge usage is not exported. Premium requests are not AI credits or currency.
Nested stage, agent and API durations are not added into cycle wall clock. Root queue/setup, telemetry export, artifact upload and later dashboard publication are excluded.
PR evidence is an as-of snapshot before publication completes. Final-for-orchestrator metrics are emitted to self-improvement-cycle.json in the root self-improvement-feedback artifact and its Actions summary when persistence succeeds; a running checkpoint is not final evidence.
Root run: https://github.com/microsoft/BC-ALAgentsInternal/actions/runs/39436159441/attempts/1