Repository navigation
Add BC performance knowledge from OptimAL learnings - #198
Jesper Schulz-Wedde (JesperSchulz) merged 3 commits into
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Jesper Schulz-Wedde (JesperSchulz)
left a comment
There was a problem hiding this comment.
The package is close, but review of af94c135ad2dd7f71f8aec61916d37c2715abe79 found three substantive issues:
design-covering-keys-from-read-pattern.good.alcallsByCustomerDatecovering while omitting the system fields Business Central always projects (SystemIdand the four audit fields). Either include every automatically projected field and discuss the write cost, or describe this as a predicate-supporting rather than covering index.cache-repeated-filtered-results-with-explicit-scope.bad.aldoes not establish repeated complete keys. If all item numbers are distinct, the dictionary adds overhead without reuse, yet evaluation requires a finding. Make meaningful reuse structurally evident and require that evidence in routing.- The materially changed
use-setloadfields-for-partial-recordsandprefer-modifyall-over-per-row-modifycompanion pairs are absent from the performance evaluation override. Register them so positive and clean retrieval behavior is covered.
I cannot formally request changes on my own PR, so this exact-head review is recorded as a comment.
Clarify predicate-supporting keys versus covering queries, demonstrate proven cache reuse, and evaluate the updated partial-load and bulk-update rules. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Jesper Schulz-Wedde (JesperSchulz)
left a comment
There was a problem hiding this comment.
Reviewed the fix at 821d62f16f90eec609a8be77ae078351ad370064. All three prior blockers are resolved: the index guidance no longer falsely claims the sample is covering once automatically projected system fields are considered; the cache fixture now establishes repeated complete-key reuse across two passes and routing requires that evidence; and the SetLoadFields/ModifyAll pairs are registered for positive and clean evaluation. All current checks pass, and I found no coupled merge-critical defect. Content is ready from this review; GitHub does not allow me to approve my own PR.
Preserve the reviewed performance package while incorporating the strengthened deterministic review-fixture coverage contract. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Jesper Schulz-Wedde (JesperSchulz)
left a comment
There was a problem hiding this comment.
Conflict resolution reviewed at b67e048070e8073f028dccbcde2cee1cec6f52b6. The merged performance routing preserves the previously reviewed guidance and incorporates current main; no evaluation registrations were lost. The strengthened changed-paired contract is satisfied by deterministic registration of the five additional changed performance articles, with retrieval cues updated where needed. Local frontmatter, knowledge index/retrieval, skill index/schema, 152 review-fixture cases, review contract, and git diff --check all pass. GitHub reports the PR mergeable and non-conflicting. Content is ready; formal self-approval is unavailable.
…crosoft#198, microsoft#202) into document-distribution-batch Resolve evaluation/review-fixtures.json semantically: data-modeling articles list is the union of main's list and this PR's nine articles; everything else is taken from main unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Summary
SetCurrentKeycase.Attribution
This contribution was informed by engineering learnings and feedback gathered through the Business Central OptimAL Performance Initiative. The examples are original and generalized; no partner- or customer-specific code, identities, review results, or measurements are included.