Skip to content

Aligining Library Assert and Assert library - #9111

Merged
Nikola Kukrika (nikolakukrika) merged 4 commits into
mainfrom
bugs/AlingLibraryAssertWithAssert
Jul 10, 2026
Merged

Nikola Kukrika (nikolakukrika) merged 4 commits into
mainfrom
bugs/AlingLibraryAssertWithAssert

Conversation

@nikolakukrika

@nikolakukrika Nikola Kukrika (nikolakukrika) commented Jul 6, 2026 •

Copy link
Copy Markdown
Contributor

What & why

Library assert is missing few helper methods that are present on Assert library. We should move the helpers to the new library and have the old library call the new library.

Linked work

Fixes AB#641493

How I validated this

  • I read the full diff and it contains only changes I intended.
  • I built the affected app(s) locally with no new analyzer warnings.
  • I ran the change in Business Central and confirmed it behaves as expected.
  • I added or updated tests for the new behavior, or explained below why none are needed.

What I tested and the outcome (required — be specific: scenarios, commands, screenshots for UI changes)

Risk & compatibility

@nikolakukrika
Nikola Kukrika (nikolakukrika) requested a review from a team July 6, 2026 08:18
@github-actions github-actions Bot added this to the Version 29.0 milestone Jul 6, 2026
@github-actions

github-actions Bot commented Jul 6, 2026 •

Copy link
Copy Markdown
Contributor

Copilot PR Review

Iteration 4 · Outcome: completed

All applicable sub-skills completed; upgrade and UI sub-skills were not-applicable (no upgrade/install/schema or page/UI files in the diff); security and privacy sub-skills found no domain-applicable knowledge (no auth/secrets/telemetry surfaces changed, and the touched files are test libraries, excluded by privacy's own worklist rule). No findings met the severity/precision bar.

Knowledge source: https://github.com/microsoft/BCQuality@822cae1b2771ac25f665f73369f69093bd4fd630

Orchestrator pre-filter (13 file(s) excluded)

  • layer-disabled (knowledge) : 13 file(s)

Findings produced by the Copilot CLI agent against BCQuality at 822cae1b2771ac25f665f73369f69093bd4fd630. Reply 👎 on any inline comment to flag false positives.

…nnotFind

Addresses PR review feedback: AllObjWithCaption primary key is fully known,
so a key seek with Get expresses intent better than SetRange + FindFirst.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…CannotFind

Addresses PR review feedback: public procedures on the Library Assert
library codeunit require XML docs describing intent and parameters.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The Assert codeunit (130000) has no namespace declaration, so the using
directive caused compile error AL0789. The 'Library Assert' codeunit is
referenced by object name, which resolves without a using directive.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Merged via the queue into main with commit b218127 Jul 10, 2026
947 of 974 checks passed
@nikolakukrika
Nikola Kukrika (nikolakukrika) deleted the bugs/AlingLibraryAssertWithAssert branch July 10, 2026 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants