Repository navigation
Aligining Library Assert and Assert library - #9111
Merged
Nikola Kukrika (nikolakukrika) merged 4 commits intoJul 10, 2026
Merged
Conversation
Contributor
Copilot PR ReviewIteration 4 · Outcome: completed
Knowledge source: https://github.com/microsoft/BCQuality@822cae1b2771ac25f665f73369f69093bd4fd630 Orchestrator pre-filter (13 file(s) excluded)
Findings produced by the Copilot CLI agent against BCQuality at |
Jesper Schulz-Wedde (JesperSchulz)
previously approved these changes
Jul 6, 2026
…nnotFind Addresses PR review feedback: AllObjWithCaption primary key is fully known, so a key seek with Get expresses intent better than SetRange + FindFirst. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…CannotFind Addresses PR review feedback: public procedures on the Library Assert library codeunit require XML docs describing intent and parameters. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The Assert codeunit (130000) has no namespace declaration, so the using directive caused compile error AL0789. The 'Library Assert' codeunit is referenced by object name, which resolves without a using directive. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Nikola Kukrika (nikolakukrika)
enabled auto-merge
July 9, 2026 21:08
Jesper Schulz-Wedde (JesperSchulz)
approved these changes
Jul 10, 2026
Onat Buyukakkus (onbuyuka)
approved these changes
Jul 10, 2026
Nikola Kukrika (nikolakukrika)
deleted the
bugs/AlingLibraryAssertWithAssert
branch
July 10, 2026 13:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Library assert is missing few helper methods that are present on Assert library. We should move the helpers to the new library and have the old library call the new library.
Linked work
Fixes AB#641493
How I validated this
What I tested and the outcome (required — be specific: scenarios, commands, screenshots for UI changes)
Risk & compatibility