Repository navigation
Conversation
Added a comment explaining the rounding error related to the tolerance calculation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #40.
The
get_leafboundary tolerance was scaled by the predicted bucket number, but therounding error of
a*key+bscales with|a*key| + |b|. After a left root expansion(
b +=number of new children), boundary keys could be routed to an emptyneighbouring leaf and become unreachable.
Tested with
alex_fuzz.cppfrom #40 (400 random datasets, descending inserts,g++ -O3 -DNDEBUG -march=native): 88/400 datasets lost keys before, 0/400 after,reproduced on two different machines.