Repository navigation
Feature: async validate support - #96
jankapunkt wants to merge 8 commits into
Conversation
|
@nachocodoner @italojs is this on your radar? |
|
Thanks for the PR @jankapunkt, the 1. Meteor 2.x can't work with the current test dependencies
So the test suite can't even resolve on 2.3 / 2.16. The new test 2. After 3. Async validators don't short-circuit on the client with Meteor 3's client Smaller things: CHANGELOG and version bump are missing (dropping Meteor 1 is breaking), and the |
|
@harryadel thanks for the thorough testing, fixing these and get back to you |
* fix: run headless with 100% coverage and 2x/3x compat * fix: make ci compatible with mulziple lock files * fix: error handling for unsupported callAsync * fix: handle missing test case on supported vs unsupported callAsync * fix: add missing guard clause to tests to support 2.3 * fix: add missing 2.3 test
|
@harryadel here are the fixes:
|
This PR is adding support for async
validatefunctions (#94). By doing so, this library now supports SimpleSchema 3+ (thanks to @harryadel) which now is fully async.The implementation is fully backwards compatible!
As a side effect and to ensure this backwards compatibility, the entire test suite has been massively extended and enriched by code coverage generation. Additionally, the
package.jsonallows to extend this library with respective linting tooling (not covered by this PR).The files in coverage-support are solely for collecting coverage and are not added to the package or have any influence on the package execution logic or workflow.
New coverage is after added over 30 new tests:
Finally, I added a CI file as an example setup and an
test:ciscript.Alltogether this PR is expected to improve the library in terms of reliability and long term maintainability.
@nachocodoner @italojs I cannot request you as reviewers somehow so I instead directly mention you here :-)