Skip to content

working reference version - #2

Merged
metasoarous merged 1 commit into
metasoarous:manual-jdk-clojure-installfrom
jjtolton:working-reference
Sep 3, 2022
Merged

working reference version#2
metasoarous merged 1 commit into
metasoarous:manual-jdk-clojure-installfrom
jjtolton:working-reference

Conversation

@jjtolton

@jjtolton jjtolton commented Sep 3, 2022 •
edited
Loading

Copy link
Copy Markdown

see discussion in: clj-python/libpython-clj#212

@jjtolton jjtolton changed the title wokring reference version working reference version Sep 3, 2022
@jjtolton jjtolton mentioned this pull request Sep 3, 2022
Closed
metasoarous
metasoarous reviewed Sep 3, 2022
View reviewed changes
Comment thread src/libpython_test/test.clj
;(require 'libpython-clj2.metadata)

(println :OK)
(defn -main []

@metasoarous metasoarous Sep 3, 2022

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this necessary to get things working? You'll see in clj-python/libpython-clj#213 that moving requirement of libpython-clj2.require conflicts a bit with what I'm trying to accomplish.

@jjtolton jjtolton Sep 3, 2022

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, not necessary, just for testing purposes so that clj -m libpython-test.test would run and print :OK and then exit gracefully. Was just to verify that libpython-clj would load correctly.

@metasoarous
metasoarous changed the base branch from master to manual-jdk-clojure-install September 3, 2022 21:21
@metasoarous

metasoarous commented Sep 3, 2022

Copy link
Copy Markdown
Owner

Thanks again for putting this together @jjtolton! I'm merging into a manual-jdk-clojure-install branch, so we can tinker with this approach separately from the one I used to get things working in the require-init-bug branch (which dropped down to jdk-8 via the official clojure docker images from docker hub).

@metasoarous
metasoarous merged commit effd7ac into metasoarous:manual-jdk-clojure-install Sep 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@metasoarous metasoarous metasoarous left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jjtolton @metasoarous