Skip to content
This repository was archived by the owner on Jun 26, 2020. It is now read-only.

[Electron] Add loadingStatus handler for replace #loading-status text set - #497

Merged
gaearon merged 1 commit into
meta:masterfrom
jhen0409:patch-8
Feb 8, 2017
Merged

[Electron] Add loadingStatus handler for replace #loading-status text set#497
gaearon merged 1 commit into
meta:masterfrom
jhen0409:patch-8

Conversation

@jhen0409

@jhen0409 jhen0409 commented Feb 8, 2017

Copy link
Copy Markdown
Contributor

Currently we need to set #loading-status div to make react-devtools-core/standalone work, provide a way to replace it will be better for me:

require('react-devtools-core/standalone')
  .setContentDOMNode(document.getElementById('container'))
  .loadingStatus(message => console.log(message))
  .startServer(port);

@jhen0409 jhen0409 mentioned this pull request Feb 8, 2017
Closed
22 of 28 tasks
@gaearon
gaearon merged commit 75d8025 into meta:master Feb 8, 2017
@gaearon

gaearon commented Feb 8, 2017

Copy link
Copy Markdown
Contributor

Awesome, thanks! I tweaked the API a tiny bit in dd9d941.

@jhen0409
jhen0409 deleted the patch-8 branch February 11, 2017 13:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

CLA Signed GH Review: review-needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jhen0409 @gaearon @facebook-github-bot