Skip to content

Support lowercase testid fallback in React Native UI events - #314

Merged
schwartzmx merged 1 commit into
meta:mainfrom
schwartzmx:fix/react-native-testid-fallback
Nov 16, 2026
Merged

schwartzmx merged 1 commit into
meta:mainfrom
schwartzmx:fix/react-native-testid-fallback

Conversation

@schwartzmx

Copy link
Copy Markdown
Member
  • Fall back to testid when testID is missing, empty, or invalid.
  • Preserve canonical testID precedence and existing identifier provenance.
  • Apply the fallback to outer controls and forwarded descendant identity.
  • Avoid reading the fallback when a valid canonical identifier is present.
  • Add extraction and mounted UI-event regressions without changing web behavior or public schemas.

Validation: 140 React Native tests, 72 web AutoLogging tests, TypeScript, targeted ESLint/Prettier, and all three runtime/heap benchmarks passed.

- Fall back to testid when testID is missing, empty, or invalid.
- Preserve canonical testID precedence and existing identifier provenance.
- Apply the fallback to outer controls and forwarded descendant identity.
- Avoid reading the fallback when a valid canonical identifier is present.
- Add extraction and mounted UI-event regressions without changing web behavior or public schemas.

Validation: 140 React Native tests, 72 web AutoLogging tests, TypeScript, targeted ESLint/Prettier, and all three runtime/heap benchmarks passed.
@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 16, 2026
@schwartzmx
schwartzmx merged commit aa2acba into meta:main Nov 16, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant