Repository navigation
Share AutoLogging primitives across web and React Native - #307
Draft
schwartzmx wants to merge 6 commits into
Draft
schwartzmx wants to merge 6 commits into
schwartzmx wants to merge 6 commits into
Conversation
- Add the generated Surface chunk to the expected web distribution manifest. - Lock the core AutoLogging and split Surface import/export boundaries independently. - Preserve the aggregate public API and generated runtime behavior.
- Pin the root development React runtime to the Web workspace's React 18 version. - Keep the React Native workspaces on their exact React 19 runtime and renderer versions. - Verify Metro aliases all application and package imports to the test app's single React copy. - Prevent npm 11 from hoisting an incompatible React runtime into React Native tests. - Leave shipped Web and mobile APIs unchanged.
- Rename the protected callback-unwrapping seam to getOriginalCallback. - Represent the AutoLogging channel with the exact ResilientChannel type. - Construct the resilient implementation directly without an unsafe assertion or extra runtime subclass. - Preserve strict and resilient listener behavior with focused regression coverage. - Leave existing Web channel semantics unchanged.
- Make Web ALSurfaceData use the portable hierarchy and inherited-property base already consumed by React Native. - Keep DOM element storage and lookup exclusively in the Web implementation. - Keep React Context, committed lifecycle state, and empty native elements exclusively in React Native. - Preserve Web registry, duplicate-name, inheritance, and removal behavior. - Add compatibility assertions around the shared base without changing public surface APIs.
- Extract the common inactivity gate and heartbeat dispatch policy into a platform-neutral controller. - Keep document visibility, window focus, and TimedTrigger scheduling in the Web adapter. - Keep injected AppState transitions and interval scheduling in the React Native adapter. - Preserve Web event shapes, timestamps, ordering, defaults, and listener cleanup. - Preserve React Native lifecycle, activity-refresh, and cleanup behavior. - Cover inactivity suppression and strict-delivery state behavior without increasing the bundle budget.
- Pin the TypeScript ESLint facade, parser, and plugin to the same published release. - Prevent lockless CI installs from selecting a partially replicated release. - Keep application, web, and React Native runtime behavior unchanged.
schwartzmx
force-pushed
the
rn-al-plugins-review/27-build-validation
branch
from
October 14, 2026 22:12
256568e to
7c2be5a
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getOriginalCallback()and making the AutoLogging channel a concreteResilientChannelsubclass. Strict and resilient listener behavior remains unchanged.TimedTrigger; React Native retains injected AppState lifecycle and interval scheduling.Commits
865d1800— Address Hook and AutoLogging channel review feedback07952e0b— Share surface hierarchy behavior across web and nativeac8024f9— Share heartbeat inactivity control across web and nativeTest plan
Run Hook and channel regression tests:
Run web surface and heartbeat compatibility tests:
npm test --workspace hyperion-autologging -- --runInBand ALSurfaceDataCompatibility.test.ts ALHeartbeat.test.ts ALHeartbeatController.test.tsRun React Native heartbeat and lifecycle coverage:
npm test --workspace hyperion-react-native -- --runInBand ALLifecycle.test.tsValidate workspace types and both distributions:
Run targeted lint and formatting checks for the changed files.
Confirm the web artifact manifest and existing generated web bundles are unchanged.
Confirm mobile heartbeat still emits the expected active/inactive/background transitions, suppresses events after inactivity, and removes timers/listeners on disposal.