Repository navigation
Conversation
conradev
force-pushed
the
transaction-memoization
branch
from
November 3, 2016 21:56
a6855b1 to
20576b3
Compare
Author
|
Would you be able to give this a look @ocrickard? |
Contributor
|
Alright, sorry for the delay, this isn't something that I think we should add. I'd like to reduce the interface of memoization in our core. Let me take a bit to do some more investigation, but my guess is we won't merge this in favor of moving up the calls into user-space. |
Contributor
|
@conradev can you take a look at #678 and let me know if that would work for you instead? You just wrap your hierarchy at the root with a memoizing component, and it will work in whatever rendering context you use, legacy datasources, transactional datasources, hosting views, etc. so long as the scope tree is properly configured. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an updated version of #477 with tests, per #477 (comment)