Repository navigation
Conversation
Contributor
Author
|
Related to #316. |
Contributor
There was a problem hiding this comment.
Instead, use c.scopeHandle.rootIdentifier which is a unique identifier for its scope frame that persists across state updates.
darknoon
force-pushed
the
memoize-state
branch
from
August 18, 2015 22:33
7ed0343 to
3d5fc1d
Compare
facebook-github-bot
added
GH Review: review-needed
and removed
GH Review: needs-revision
labels
Contributor
Author
There was a problem hiding this comment.
I should use CKAssert or whatever here
darknoon
force-pushed
the
memoize-state
branch
from
August 19, 2015 17:51
3d5fc1d to
ed677f9
Compare
Contributor
|
Reviewing now... |
Contributor
There was a problem hiding this comment.
This already exists as scopeFrameToken, can we just use that?
Contributor
There was a problem hiding this comment.
Ah I see why you didn't and exposed this instead. Will consider...
Contributor
|
Perfect, let's clean it up and land it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work in progress, via discussions with @adamjernst. Need to clean up the
id scopeIdentifierparameter, which shouldn't be necessary.