Repository navigation
add heltec v4 board. - #813
Conversation
|
I just started experimenting with the V4 board I was sent, then .. your PR came in! |
|
|
||
| #ifdef PIN_GPS_RESET | ||
| pinMode(PIN_GPS_RESET, OUTPUT); | ||
| digitalWrite(PIN_GPS_RESET, PIN_GPS_RESET_ACTIVE); // assert for 10ms |
There was a problem hiding this comment.
It would have been nice to give a default value to PIN_GPS_RESET_ACTIVE ... ;)
Because now compilation breaks on TEcho (at least)
I think reset is handled in MicroNMEALocationProvider ...
I'll see how I can clean this mess
There was a problem hiding this comment.
this is where gps reset is done
MeshCore/src/helpers/sensors/MicroNMEALocationProvider.h
Lines 51 to 57 in ea13fa8
I agree the GPS_RESET_FORCE symbol could be changed to PIN_GPS_RESET_ACTIVE but it has been here for a long time now ...
There was a problem hiding this comment.
the big issue is that EnvironmentSensorManager is a big mess regarding GPS management ...
I won't be able to fix everything ... will just try to make things work, but there is a need for some rewriting here ...
There was a problem hiding this comment.
See #820
I've tried to use the symbols introduced in this PR ... so it should work on heltec_v4, but would need to be verified
add heltec v4 board.
add heltec v4 board.
This board has PA, so to comply with regulations, the maximum output of sx1262 is 10.