Skip to content

add heltec v4 board. - #813

Merged
ripplebiz merged 2 commits into
meshcore-dev:devfrom
Quency-D:dev-heltec_v4
Sep 22, 2025
Merged

ripplebiz merged 2 commits into
meshcore-dev:devfrom
Quency-D:dev-heltec_v4

Conversation

@Quency-D

Copy link
Copy Markdown
Contributor

This board has PA, so to comply with regulations, the maximum output of sx1262 is 10.

@ripplebiz

Copy link
Copy Markdown
Member

I just started experimenting with the V4 board I was sent, then .. your PR came in!

@ripplebiz
ripplebiz merged commit 4579a1b into meshcore-dev:dev Sep 22, 2025

#ifdef PIN_GPS_RESET
pinMode(PIN_GPS_RESET, OUTPUT);
digitalWrite(PIN_GPS_RESET, PIN_GPS_RESET_ACTIVE); // assert for 10ms

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would have been nice to give a default value to PIN_GPS_RESET_ACTIVE ... ;)
Because now compilation breaks on TEcho (at least)

I think reset is handled in MicroNMEALocationProvider ...

I'll see how I can clean this mess

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is where gps reset is done

void reset() override {
if (_pin_reset != -1) {
digitalWrite(_pin_reset, GPS_RESET_FORCE);
delay(100);
digitalWrite(_pin_reset, !GPS_RESET_FORCE);
}
}

I agree the GPS_RESET_FORCE symbol could be changed to PIN_GPS_RESET_ACTIVE but it has been here for a long time now ...

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the big issue is that EnvironmentSensorManager is a big mess regarding GPS management ...

I won't be able to fix everything ... will just try to make things work, but there is a need for some rewriting here ...

@fdlamotte fdlamotte Sep 23, 2025 •

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #820

I've tried to use the symbols introduced in this PR ... so it should work on heltec_v4, but would need to be verified

agessaman pushed a commit to agessaman/MeshCore that referenced this pull request Nov 8, 2025
Alohataiti pushed a commit to Alohataiti/MeshCore that referenced this pull request Oct 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants