Skip to content

State of rp2350 support effort? #3872

Open

Description

@gdahlm

There are several reverts, dead issues, and it is hard to tell what is happening and I want to help but need some guidance.

E.G. a this revert is saying it is a duplicate effort in recrof@b44f010 in this message: #3792 (comment)

I also have a well developed version off of dev, and would like to add some of the parts that I feel the original Waveshare version was lacking as well as take advantage of some of the RP2350 features.

The three RP2350 efforts: (That I know of)

nminaylov PR #3756 (merged Nov 3, reverted Nov 10) recrof WIP b44f010b (on his fork's dev, never merged upstream) Mine
What New variants/rpi_pico2/, bare Pico 2 + SX1262 No new variant: adds [rpi_pico2w]/Pico2W_* envs inside existing variants/rpi_picow/ New variants/waveshare_pico_lora_rp2350/ (the HAT)
Base extends = rp2040_base, board = rpipico2, zero new defines Same: reuses rpi_picow base, chip diff via core's own PICO_RP2350 New rp2350_base + RP2350_PLATFORM + HW SHA-256
LoRa Pins 10/11/12 defined but std_init(&SPI1) with no pin remap; arduino-pico SPI1 defaults to GP16/17/18, and broke for me n/a (bare board) 10/11/12 + explicit SPI1 remap: hardware verified
GPS / I2C sensors None (SensorManager sensors; plain) None Default UART0 GP0/GP1 GPS / Default GP4-GP5 + BMP3XX (BMP388/390 verified)
Companion envs BLE/WiFi commented out Yes: harmonized, uses the MAX_CONTACTS=350/MAX_GROUP_CHANNELS=40 Yes: USB+BLE simultaneous, 350/40
HW SHA-256 No No Yes (accelerator + software fallback)
  1. I'm not not duplicating either effort. as the others don't fix the Waveshare HAT. nminaylov's was a bare-board variant and recrof's is the bare Pico 2 W with no LoRa at all.
  2. A friction point: My rp2350_base + RP2350_PLATFORM diverges from the recrof's model (no new project defines; chip selection via board= and the core's PICO_RP2350). If that WIP lands upstream first, my base section looks redundant. I can align by dropping rp2350_base, have the variant extend rp2040_base directly. But USE_RP2350_HW_SHA256 as the feature gate is worth it in my testing.
  3. I get larger changes should get a maintainer 👍 first, which is what I am looking for here.

Mine is a HAT variant, complementary to recrof's rpi_picow RP2350 WIP; happy to drop rp2350_base and extend rp2040_base if you prefer, but there were enough changes that it felt like a lot of if-else to implement that way. Especially with future additions like power management but I realize that may be a lack of creativity on my part.

As all the previous RP2350 issues have been closed due to inaction I had to open another one here, but some guidance would be nice. I have been running most of my code for several weeks now.

Thanks again and I hope I can help out a little here.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions