Skip to content

feat(client): use the GA API versions of building blocks and their definitions - #84

Draft
grubmeshi wants to merge 1 commit into
mainfrom
feature/make-bb-bbd-ga
Draft

grubmeshi wants to merge 1 commit into
mainfrom
feature/make-bb-bbd-ga

Conversation

@grubmeshi

@grubmeshi grubmeshi commented Nov 13, 2026 •

Copy link
Copy Markdown
Collaborator

🤖 Written by AI agent

meshStack promotes meshBuildingBlock v2 and meshBuildingBlockDefinition and meshBuildingBlockDefinitionVersion v1 to GA (meshcloud/meshfed-release#11641). The client now sends the GA media types v2 and v1, and MinMeshStackVersion rises from 2026.36.0 to 2026.47.0. The building block runner and API key clients stay on their preview versions.

The test fixtures and the demo API docs keep v2-preview: they test how a preview version is picked in general, and the demo snapshots meshStack 2026.39.0, which docs/demo.gif shows.

Do not merge before meshStack R is released. R is the first meshStack release that contains meshfed-release#11641. R is tentatively meshStack 2026.47.0; the version in this draft gets updated if R turns out later.

The Terraform provider follows in a PR that pins this branch: meshcloud/terraform-provider-meshstack#396.

🤖 Generated with Claude Code

…finitions

meshBuildingBlock v2 and meshBuildingBlockDefinition and its version v1 are GA
from meshStack 2026.47.0, so the client sends their GA media types and needs
that version at least.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@meshcloud-gh-actions

Copy link
Copy Markdown

Coverage of the acceptance run against the meshStack backend, on 1e8a9a8d460f355ccaba776fb7915f45654035ce.

Scope Coverage
Unit tests 78.2%
Acceptance tests not reported
Combined 78.2%

No acceptance coverage. The acceptance suite ended as failure, so the figures cover the unit half only.

Uncovered functions
client/api_key.go:52: meshApiKeyClient.Create 0.0%
client/api_key.go:56: meshApiKeyClient.Read 0.0%
client/api_key.go:60: meshApiKeyClient.Update 0.0%
client/api_key.go:64: meshApiKeyClient.Delete 0.0%
client/api_key_permissions.go:20: ApiKeyPermissions.AllCodes 0.0%
client/api_key_permissions.go:33: ApiKeyPermissions.WorkspaceCodes 0.0%
client/api_key_permissions.go:262: AllApiKeyPermissions 0.0%
client/api_key_permissions.go:266: WorkspacePermissionCodes 0.0%
client/building_block_definition.go:71: MeshBuildingBlockDefinitionApprovalPolicies.NothingRequiresApproval 0.0%
client/building_block_definition.go:82: DisabledSchedule 0.0%
client/building_block_definition.go:89: MeshBuildingBlockDefinitionSchedule.IsDisabled 0.0%
client/building_block_definition.go:93: MeshBuildingBlockDefinitionSpec.HasNeutralPolicies 0.0%
client/building_block_definition.go:97: MeshBuildingBlockDefinitionSpec.WithNeutralPolicies 0.0%
client/building_block_definition.go:166: meshBuildingBlockDefinitionClient.List 0.0%
client/building_block_definition.go:173: meshBuildingBlockDefinitionClient.Read 0.0%
client/building_block_definition.go:177: meshBuildingBlockDefinitionClient.Create 0.0%
client/building_block_definition.go:181: meshBuildingBlockDefinitionClient.Update 0.0%
client/building_block_definition.go:185: meshBuildingBlockDefinitionClient.Delete 0.0%
client/building_block_definition_version.go:101: MeshBuildingBlockType.TagInputTargets 0.0%
client/building_block_definition_version.go:245: meshBuildingBlockDefinitionVersionClient.Create 0.0%
client/building_block_definition_version.go:254: meshBuildingBlockDefinitionVersionClient.Update 0.0%
client/building_block_definition_version_implementation.go:81: MeshBuildingBlockDefinitionImplementation.InferType 0.0%
client/building_block_definition_version_implementation.go:95: MeshBuildingBlockDefinitionImplementation.MarshalJSONTo 0.0%
client/building_block_definition_version_implementation.go:108: *MeshBuildingBlockDefinitionImplementation.UnmarshalJSONFrom 0.0%
client/building_block_run.go:80: meshBuildingBlockRunClient.GetLogs 0.0%
... and 154 more

covdata func names a method without its receiver, so an entry can belong to an implementation nothing selects rather than to a function the tests never reached. Open the file and line before reading one as a coverage gap.

@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant