Repository navigation
Fix mapping category crashes and settings persistence - #12
Merged
Merged
Conversation
meanmail
marked this pull request as ready for review
November 2, 2026 11:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Double-clicking a category or root label now leaves the mappings unchanged instead of casting its String label to MappingEntry. Mapping bean properties also retain their values through the IDE XML serializer; previously native settings saves produced empty mapping elements.
Update Gradle to 9.8.2, the IntelliJ build plugin to 2.19.0 and the build SDK to PyCharm 2025.1.6.2. Export metadata reads the packaged version resource. CI uses JDK 21 and Xvfb on hosted Ubuntu, retaining strict compatibility verification including the IDE 243 floor. The working version is 2026.0, unreleased.
Validation: exact-head Main and wrapper validation passed; three regression tests, full build and five IDE verifier targets passed. Test-first runs reproduced the category cast and empty XML values. Native IDEA 253 checks covered settings edit/cancel/persistence, folding, exact source Save/Undo/Redo, reopen, split frontend category/Edit Mapping/Cancel, same-client reconnect and enabled/absent resource controls. Native JSON export retained all six mappings and version 2026.0. Native import completion remains unverified because the 253 Aqua file chooser lacks a qualified file-selection adapter. No Marketplace publication is included.