Repository navigation
Conversation
go1.27.3 is the latest 1.27 release. The Makefile pins it, and go.mod gets a toolchain go1.27.3 line, so the script suite and CI use it too: script_test.go runs the scripts with the toolchain go.mod names (goModToolchain), and actions/setup-go reads the same file. Bumping only the Makefile, as #1 does, would have left every script, and the claim that flag_methods_ice.txt checks the crash on 1.27.3, on go1.27.1. The go line stays at 1.27.1, the first release whose simd package works with the code loopvec generates (go1.27.0 compiles ShiftAllRight with a uint8 count), so go install still accepts a 1.27.1 toolchain. go1.27.3's simd package has the same methods as go1.27.1's: make generate only changes the header of caps_gen.go. The -methods internal compiler error (golang/go#80657) is still there, and flag_methods_ice.txt now checks that on go1.27.3.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This bumps the pinned toolchain from go1.27.1 to go1.27.3, the latest 1.27 release. It supersedes the go1.27.3 commit in #1.
That commit bumped only the Makefile. The script harness doesn't read the Makefile:
script_test.goruns every script with the toolchaingo.modnames (goModToolchain), andactions/setup-goreads the same file. With only the Makefile changed, the scripts would still have run on go1.27.1, including theflag_methods_ice.txtcheck behind the claim that the crash is still in 1.27.3.This PR:
go1.27.3, andgo.modgets atoolchain go1.27.3line.goline stays at1.27.1, the first release whose simd works with what loopvec generates: go1.27.0 compilesShiftAllRightwith auint8count.caps_gen.go. go1.27.3's simd package has the same methods as 1.27.1's, so only the header comment changes.BUGS.mdandflag_methods_ice.txt. The-methodsinternal compiler error (cmd/compile: simd use in a method causes "internal compiler error: missing Types entry" golang/go#80657) still happens on go1.27.3, and the script checks that now.Tested locally:
make cipasses on this commit:test-updateleaves the goldens unchanged, and the race suite, both arm64 qemu runs, bench fuzz seeds, tsvc, fix and lint all pass.GOTOOLCHAIN=go1.27.3, andflag_methods_ice.txtstill gets the internal compiler error.