CFI build failing on travis #166

Activity

1. artemp commented on Dec 7, 2020

   

   artemp

   on Dec 7, 2020

   Contributor

   More actions

   The issue is cfi sanitizer doesn't like CRTP pattern cast here: https://github.com/nodejs/node-addon-api/blob/master/napi-inl.h#L3545

   Process 27867 launched: '/opt/node/bin/node' (x86_64)
   TAP version 13
   # success: prints expected string
   Process 27867 stopped
   * thread #1, name = 'node', stop reason = signal SIGILL: illegal instruction operand
       frame #0: 0x00007ffff52271c2 module.node`Napi::ObjectWrap<object_sync::HelloObject>::ObjectWrap(this=0x00005555577d10c0, callbackInfo=0x00007fffffffc1a8) at napi-inl.h:3545:17
      3542	  napi_value wrapper = callbackInfo.This();
      3543	  napi_status status;
      3544	  napi_ref ref;
   -> 3545	  T* instance = static_cast<T*>(this); <===================== FAIL  
      3546	  status = napi_wrap(env, wrapper, instance, FinalizeCallback, nullptr, &ref);
      3547	  NAPI_THROW_IF_FAILED_VOID(env, status);
      3548	
   

   I'll submit PR with the fix (disabling cfi-derived-cast check for any functions which has 'ObjectWrap` string in its name.
2. artemp commented on Dec 7, 2020

   

   artemp

   on Dec 7, 2020

   Contributor

   More actions

   Fixed in #167