Skip to content

WinBar adds another MacVim menu in the menu bar #918

Closed
#1126
Closed
WinBar adds another MacVim menu in the menu bar#918
#1126
Milestone
snapshot-167

Description

@lifepillar
lifepillar
opened on Jun 29, 2019

If a window toolbar (:help WinBar) is added to a window, an additional MacVim menu appears in the app's menu bar (see screenshot below).

Detailed steps to reproduce the behavior:

  1. gvim --clean
  2. :nnoremenu 1.10 WinBar.Foo :Bar<cr>

I would expect that the window toolbar does not affect the app's menu bar. Alternatively, if a window toolbar is supposed to be replicated in the menu bar, it should be on the far right with a proper name (WinBar?) and its menu entries should be working.

macvim-toolbar-menu

  • Vim 8.1.1517
  • macOS 10.14.5

Activity

  1. eirnym commented on Jul 1, 2019

    @eirnym
    eirnym
    on Jul 1, 2019
    Contributor

    Where have you got gvim from MacVim distribution?

  2. eirnym commented on Jul 2, 2019

    @eirnym
    eirnym
    on Jul 2, 2019
    Contributor

    Btw, the step 2 is reproducable.

  3. lifepillar commented on Jul 2, 2019

    @lifepillar
    lifepillar
    on Jul 2, 2019
    ContributorAuthor

    Where have you got gvim from MacVim distribution?

    I install MacVim with brew install macvim. The Homebrew formula creates that symlink:

    # Create MacVim vimdiff, view, ex equivalents
executables = %w[mvimdiff mview mvimex gvim gvimdiff gview gvimex]
executables += %w[vi vim vimdiff view vimex]
executables.each { |e| bin.install_symlink "mvim" => e }

    So, it's just a symlink to mvim:

    ls -l `which gvim`
lrwxr-xr-x  1 me  admin  42 Jun 11 20:51 /usr/local/bin/gvim -> /Applications/MacVim.app/Contents/bin/mvim

  4. eirnym commented on Jul 2, 2019

    @eirnym
    eirnym
    on Jul 2, 2019
    Contributor

    I think it's a bad idea as gvim and mvim are different by nature. People expect to see GTK Vim instead of MacVim. I'd filed an issue to that formula on this.

  5. lifepillar commented on Jul 2, 2019

    @lifepillar
    lifepillar
    on Jul 2, 2019
    ContributorAuthor

    I don't know, MacVim is the only GUI Vim I use. I'd just note that in MacVim's app bundle, under Contents/bin one finds gview, gvim and gvimdiff as well.

  6. eirnym commented on Jul 3, 2019

    @eirnym
    eirnym
    on Jul 3, 2019
    Contributor

    My bad, I see symlinks. Didn't know that they appeared. a while ago there were no such symlinks. Thank you for an issue

  7. ychin commented on Jul 7, 2019

    @ychin
    ychin
    on Jul 7, 2019
    Member

    I think it's fine to map gvim to mvim personally. The command line flags should mostly work. But yes this is a bug that should be fixed.

  8. ychin
    added this to the snapshot-157 milestone on Jul 7, 2019
  9. ychin
    modified the milestones: snapshot-157, snapshot-158 on Jul 17, 2019
  10. ychin
    modified the milestones: snapshot-158, snapshot-159 on Oct 16, 2019
  11. ychin
    modified the milestones: snapshot-160, snapshot-161 on Oct 28, 2019
  12. ychin
    modified the milestones: snapshot-162, snapshot-163 on Mar 3, 2020
  13. ychin
    modified the milestones: snapshot-163, Backlog on Apr 11, 2020
  14. ychin
    modified the milestones: Backlog, snapshot-167 on Sep 21, 2020
  15. ychin
    added a commit that references this issue on Dec 7, 2020

    Fix WinBar menus in GUI, and off-by-one error when adding new menus

    5e4da5b
  16. ychin
    closed this as completedin #1126on Dec 7, 2020
  17. ychin
    added 2 commits that reference this issue on Dec 11, 2020

    MacVim Snapshot 167

    ee71f93

    MacVim Snapshot 168

    f539a14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions