Skip to content

Rows of text seem clipped at certain font sizes on Catalina #905

Closed
Closed
Rows of text seem clipped at certain font sizes on Catalina#905
Labels
10.15 Catalina
Milestone
snapshot-159

Description

@twk
twk
opened on Jun 11, 2019

Running 8.1.950 on Catalina, when I start MacVim, some lowercase letters are getting clipped:

image

If I adjust the font size and then adjust it back, things are rendered correctly:

image

This started as soon as I upgraded to Catalina -- Mojave was fine. My font settings are English/Menlo/Regular/11

Activity

  1. ychin
    added
    10.15 Catalina
    on Jun 11, 2019

  2. ychin commented on Jun 11, 2019

    @ychin
    ychin
    on Jun 11, 2019
    Member

    I will need to see if I can repro this under the new Xcode. Otherwise could be tricky as I don't have a beta Catalina install with me.

  3. adamjacobmuller commented on Jun 14, 2019

    @adamjacobmuller
    adamjacobmuller
    on Jun 14, 2019

    Happens for me after upgrading to catalina, but, only with Core Text renderer enabled.

    With Core Text renderer disabled things are actually considerably worse.

    image

    actual:

    image

  4. eirnym commented on Jun 14, 2019

    @eirnym
    eirnym
    on Jun 14, 2019
    Contributor

    I'd wait for first public beta. Before that point macOS is not really usable at all

  5. adamjacobmuller commented on Jun 14, 2019

    @adamjacobmuller
    adamjacobmuller
    on Jun 14, 2019

    Aside from the MacVim issue my workflow is fine and I've just been running vim instead.

  6. eirnym commented on Jun 15, 2019

    @eirnym
    eirnym
    on Jun 15, 2019
    Contributor

    I'm really surprised to read it! This release will be the first one with relatively stable betas, since it wasn't a case since macOS 10.7 Beta 1

  7. eirnym commented on Jun 26, 2019

    @eirnym
    eirnym
    on Jun 26, 2019
    Contributor

    Public Beta is out…

  8. eirnym commented on Jun 26, 2019

    @eirnym
    eirnym
    on Jun 26, 2019
    Contributor

    It's interesting, I can reproduce it with

    guifont=Menlo-Regular:h11, but not with guifont=Fira\ Code\ Light:h12

  9. jjgod commented on Jul 28, 2019

    @jjgod
    jjgod
    on Jul 28, 2019
    Contributor

    This is a duplicate of #883.

  10. jjgod commented on Jul 28, 2019

    @jjgod
    jjgod
    on Jul 28, 2019
    Contributor

    Oh, @eirnym, it's because the comparison sees that the new font Menlo-Regular:h11 is the same as the default font initialized by -[MMCoreTextView initWithFrame:] and skip rest of the initialization:

    if (!(newFont && font != newFont))
    return;

    That's why in this case fontDescent is still properly initialized.

  11. jjgod commented on Jul 28, 2019

    @jjgod
    jjgod
    on Jul 28, 2019
    Contributor
    (lldb) p font
(NSCTFont *) $0 = 0x0000000101c233e0
(lldb) p newFont
(NSCTFont *) $1 = 0x0000000101c233e0
(lldb) po font
"Menlo-Regular 11.00 pt. P [] (0x101c28300) fobj=0x101c233e0, spc=6.62"

(lldb) po newFont
"Menlo-Regular 11.00 pt. P [] (0x101a00860) fobj=0x101c233e0, spc=6.62"

  12. eirnym commented on Jul 28, 2019

    @eirnym
    eirnym
    on Jul 28, 2019
    Contributor

    I've tried it after Fira Code, to guarantee that it's a different one

  13. jjgod commented on Jul 28, 2019

    @jjgod
    jjgod
    on Jul 28, 2019
    Contributor

    That's why you are not hitting the problem with Fira Code.

  14. eirnym commented on Jul 28, 2019

    @eirnym
    eirnym
    on Jul 28, 2019
    Contributor

    and what's about Menlo?

    I've set Fira Code first, then Menlo, and issue still exists. This doesn't neglect your issue on fontDescent, though. Probably, in macOS Catalina this parameter becomes more valuable to set if it's not.

  15. jjgod commented on Jul 28, 2019

    @jjgod
    jjgod
    on Jul 28, 2019
    Contributor

    How exactly did you do that? Did you execute multiple set guifont command?

  16. 8 remaining items

  17. ychin commented on Oct 10, 2019

    @ychin
    ychin
    on Oct 10, 2019
    Member

    Next update will be out this weekend.

  18. hoke-t commented on Oct 14, 2019

    @hoke-t
    hoke-t
    on Oct 14, 2019

    Any updates on this?

  19. isaki commented on Oct 14, 2019

    @isaki
    isaki
    on Oct 14, 2019

    As per @eirnym, I am posting this here and closing my issue.

    I can confirm this is still an issue after the weekend.

    I am running the latest release:
    image

    And can confirm fonts still look strange:
    image

    And that the changing the font size back and forth fixes things:
    image

    My macOS version:

    % sw_vers 
ProductName:	Mac OS X
ProductVersion:	10.15
BuildVersion:	19A583

  20. eirnym commented on Oct 15, 2019

    @eirnym
    eirnym
    on Oct 15, 2019
    Contributor

    @isaki Thank you for an addition, Please, write which distribution of MacVim do you use (e.g. GitHub, Homebrew, MacPorts, etc) and which font are you using (:set guifont?)

  21. tobireif commented on Oct 15, 2019

    @tobireif
    tobireif
    on Oct 15, 2019

    changing the font size back and forth fixes things

    Here it fixes it temporarily for that one buffer/window, but not permanently.

    (I'm using the distribution from https://github.com/macvim-dev/macvim/releases plus auto-updates.)

    :set guifont? says guifont=Menlo:h16

  22. hoke-t commented on Oct 15, 2019

    @hoke-t
    hoke-t
    on Oct 15, 2019

    I have the exact issue as well. I always have to increase and then decrease the font size upon opening a file to fix the clipping.

    Using macOS 10.15 build version 19A583, Homebrew distribution of MacVim, and set guifont? gives guifont=Menlo-Regular:h11.

  23. isaki commented on Oct 15, 2019

    @isaki
    isaki
    on Oct 15, 2019

    @eirnym I am using the GitHub distribution of MacVim.

    I apparently have no font set once so ever:
    image

    Also, commands are also being chopped off:
    image

    Finally, this is the font setup that seems to be in use when I run set guifont=*:
    image

    I hope this information helps!

  24. eirnym commented on Oct 15, 2019

    @eirnym
    eirnym
    on Oct 15, 2019
    Contributor

    Thank you, this is fixed in HEAD. So I hope @ychin will find the time to prepare a release.

  25. jimsiff commented on Oct 17, 2019

    @jimsiff
    jimsiff
    on Oct 17, 2019

    Thank you @eirnym and @ychin. It's fixed for me after building 8.1.2102 on Catalina.

  26. ychin
    added 2 commits that reference this issue on Oct 17, 2019

    MacVim Snapshot 158

    eeb05f5

    MacVim Snapshot 159

    ae238e0

  27. ychin commented on Oct 17, 2019

    @ychin
    ychin
    on Oct 17, 2019
    Member

    This should be fixed in snapshot-159. Let me know if it isn't.

  28. ychin
    closed this as completedon Oct 17, 2019

  29. isaki commented on Oct 17, 2019

    @isaki
    isaki
    on Oct 17, 2019

    This has indeed fixed it, thank you!

  30. hoke-t commented on Oct 17, 2019

    @hoke-t
    hoke-t
    on Oct 17, 2019

    Can confirm as well. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    10.15 Catalina

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions