Repository navigation
Tabs do not pick dark theme on Mojave #775
Description
Tabs do not fully pick up dark theme in Mojave. Only text changes color. This results in a really low-contrast look. It wouldn't be much issue if it didn't change text color but currently it make it hard to use MacVim tabs with dark theme.
This is most probably related to #544.
Reacted by Emiliano Mancuso, phriedrich, Seekr Wang and Wayne Ye
Activity
ychin commentedon Nov 15, 2018
Are you building MacVim locally or using HomeBrew? Right now Mojave doesn't work very well due to #751 and you should see a lot of flickering when you use MacVim built for Mojave. Currently focus is on fixing that first, but I will look into the tab issues.
pointlessone commentedon Nov 15, 2018
I use Homebrew binary.
I know about #751. I have Core Text Renderer disabled. It works (doesn't flicker) apart from minor space width issues on otherwise blank lines.
bhargavshivkumar commentedon Nov 16, 2018
Is there a work around for this until #751 is resolved?
ychin commentedon Nov 17, 2018
@bhargavshivkumar You could do one of the following:
Edit: Also, this issue is unrelated to #751 so even if that issue is resolved this issue would still persist.
bhargavshivkumar commentedon Nov 20, 2018
@ychin When you say use the snapshot version i'm assuming you are saying i should install using the dmg file instead of using homebrew binaries? (sorry relatively new to the Mac way of things)
Also, is there a specific snapshot I should be downloading or is 151 also built against High Sierra?
ychin commentedon Nov 20, 2018
@bhargavshivkumar Yes I meant installing the prebuilt dmg file from Github releases (we just call them snapshots). The latest one (151) should be fine and is built against High Sierra.
I plan to merge in all Mojave support soon so Homebrew builds won't stay broken. There should be a corresponding snapshot-152 release as well and it would be built against Mojave.
Add Mojave-style tabs, which also supports Dark Mode
Add Mojave-style tabs, which also supports Dark Mode
Add Mojave-style tabs, which also supports Dark Mode
Add Mojave-style tabs, which also supports Dark Mode