MacVim doesn't hide menu bar in secondary display when using pre-Lion fullscreen  #7

Activity

1. chdiza commented on Apr 29, 2015

   

   chdiza

   on Apr 29, 2015

   Contributor

   More actions

   This is separate from the white flash issue.

   I'm going to bisect later to find out where this non-hiding appeared.
2. splhack commented on Nov 7, 2015

   

   splhack

   on Nov 7, 2015

   Contributor

   More actions

   It is still happening? and I believe you @chdiza are the only person who uses MacVim on OS X 10.4, 10.5, 10.6, and 10.7. So, could you fix the issue?
3. splhack

   added

   Deprecated OSX

   on Nov 7, 2015
4. chdiza commented on Nov 7, 2015

   

   chdiza

   on Nov 7, 2015

   Contributor

   More actions

   This issue is not in any way about old versions of OS X. It is about one of the two styles of "fullscreen behavior" we support, both of which work and are meant to work on 10.7 and up. (One of them doesn't and can't work on 10.6 or under.) Indeed, my original report of this issue is of incorrect behavior on Yosemite. The label "Deprecated OSX" is not right, so I'm going to remove it.

   As to whether this behavior is still happening, I can't test this right now since I am not at a desk with an external monitor.
5. chdiza

   removed

   Deprecated OSX

   on Nov 7, 2015
6. splhack commented on Nov 7, 2015

   

   splhack

   on Nov 7, 2015

   Contributor

   More actions

   how about 10.11? and what is the result of the bisect?
7. splhack commented on Nov 7, 2015

   

   splhack

   on Nov 7, 2015

   Contributor

   More actions

   Anyway we don't need MMFullScreenWindow for 10.10 or later. We should make MMFullScreenWindow deprecated.
8. chdiza commented on Nov 7, 2015

   

   chdiza

   on Nov 7, 2015

   Contributor

   More actions

   Anyway we don't need MMFullScreenWindow for 10.10 or later. We should make MMFullScreenWindow deprecated.

   No, no, no, a thousand times no 😄. The older style of fullscreen is preferable to the Lion-and-up style in many ways, depending on one's workflow, and not just aesthetically. My workflow depends on its existence.

   It is a giant pain in the butt to wait for the Mac's animation delay when switching into Lion-and-up mode. Also, that forces the newly-fullscreened window onto a different space than it used to be on, which is annoying enough even if it didn't carry an annoying animation delay with it. Also, it prevents there being two fully-fullscreened windows on the same space. Also, it prevents there being a fullscreened window and and non-fullscreened window on the same space. All of these things that the Lion-and-up mode prevents are sometimes useful.

   There is just no reason to drop it. It's not hurting anything, and it helps some people.

   In fact, the original fullscreen style is almost the entire reason I use MacVim rather than just vim in the console like I used to years ago.

   I know some people like the Lion-and-up style too. That's fine. We can have both without problems.
9. splhack commented on Nov 7, 2015

   

   splhack

   on Nov 7, 2015

   Contributor

   More actions

   Then, what is the result of the bisect?
10. chdiza commented on Nov 7, 2015

    

    chdiza

    on Nov 7, 2015

    Contributor

    More actions

    Then, what is the result of the bisect?

    I will do the bisect when I am sitting at a place that has an external monitor I can use for testing.
11. cristibalan commented on Nov 11, 2015

    

    cristibalan

    on Nov 11, 2015

    More actions

    I use both MacVim and iTerm2 with the non-native fullscreen option. Just got an external monitor today and hit this issue, then noticed that iTerm2 doesn't have it. This is on OS X 10.11, macvim snapshot 77 from brew cask.

    Unfortunately, I can't write objc/Cocoa, but I grepped the sources a bit and found out something.

    It seems that iTerm2 sets the menubar to autohide when entering fullscreen on all screens while MacVim sets the size of the window to be less than the toolbar.

    I have the following in my config:

    function! OnVimEnter()
      if has("macunix") && has("gui_running")
        set antialias
        set fuoptions=maxvert,maxhorz
        set fullscreen
      endif
    endfunction
    autocmd VimEnter    * call OnVimEnter()
    

    The behaviour I'm seeing is that when MacVim starts the MenuBar is fixed on top and covers part of the first row.

    

    If I then exit fullscreen and enter it again, the window positions itself under the menubar.

    

    Hope this helps.
12. hkdsun commented on Mar 9, 2016

    

    hkdsun

    on Mar 9, 2016

    More actions

    any updates on this issue? It would be nice to do what iTerm2 does.

    Like @chdiza said my workflow is having iTerm2 and MacVim overlay each other in older-style fullscreen mode and switch between them with a shortcut (or use transparent windows to see through the focused window)

    👍React with 👍1Reacted by Chief Sloperator
13. ychin

    added a commit that references this issue on Dec 27, 2020

    Fix non-native fullscreen not hiding menu/dock in secondary screens

    ...

    This issue will close once commit 479629e is merged into the 'master' branch.

    479629e
14. ychin

    added this to the snapshot-170 milestone on Dec 27, 2020
15. ychin

    added

    UIIssues related to UI elements, tabs, scrollbars, window resizing, etc.Issues related to UI elements, tabs, scrollbars, window resizing, etc.

    on Dec 27, 2020
16. ychin

    closed this as completedin #1155on Dec 27, 2020
17. ychin commented on Dec 27, 2020

    

    ychin

    on Dec 27, 2020

    Last edited by ychin

    Member

    More actions

    Kind of better late than never, but this is finally fixed! So that's the update 😅.

    Will be out in the next update (r170) along with a couple native/non-native fullscreen improvements.

    This should be the last single-digit issue to be closed. Hopefully eventually can catch up to the double-digit ones as well (we are in the 4-digit range now).
18. ychin

    added a commit that references this issue on Mar 8, 2021

    MacVim Snapshot 170

    ...

    ce8eda7