Skip to content

MacVim silently fails to save a file when a conversion error is present #671

Closed

Description

@dschuessler

Steps to reproduce:

  1. Create a text file that yields a CONVERSION ERROR when saved in Vim (e.g. when trying to save it with :w).
  2. Try to close the corresponding MacVim window (e.g. by clicking on the red wine gum).
  3. When the dialogue appears, that asks if you want to save the file, confirm.

Expected behavior: I get some alert that the file did not actually save and why.

Actual behavior: The dialogue, that asks if you want to save the file, disappears and the window simply does not close.

Activity

  1. jpetrie commented on Jul 30, 2018

    @jpetrie
    Contributor

    Do you have an example of such a file or information about how we could create one from scratch?

  2. dschuessler commented on Aug 31, 2018

    @dschuessler
    Author
    1. Open an empty buffer.
    2. :set fileencoding=latin1
    3. Write an Emoji into the buffer.
    4. Try to save as described above.
  3. eirnym commented on May 18, 2019

    @eirnym
    Contributor

    @dschuessler I reproduced the issue in terminal Vim and filled the issue to the upstream. Please, follow up there.

  4. eirnym commented on May 18, 2019

    @eirnym
    Contributor

    @ychin the underlying issue was fixed in vim-patch:8.1.1349. Please update the base

  5. ychin commented on May 19, 2019

    @ychin
    Member

    Will do. Thanks. Will close this issue after I release a new MacVim update.

  6. added this to the snapshot-156 milestone on May 19, 2019
  7. added a commit that references this issue on Jun 11, 2019
  8. ychin commented on Jun 11, 2019

    @ychin
    Member

    Released a new update. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions