Skip to content

Sign MacVim Builds #517

Closed
Closed

Description

@cycloon

It looks like MacVim.app is not signed. I get "MacVim.app can't be opened because it is from an unidentified developer."

As this is a first barrier for new users, please sign the binary.

Activity

  1. splhack commented on Jul 23, 2017

    @splhack
    Contributor

    I don't have Apple Developer Program.

  2. EarthCitizen commented on Dec 1, 2018

    @EarthCitizen

    My work laptop is locked down, so no possible way to use MacVim.

  3. ychin commented on Dec 4, 2018

    @ychin
    Member

    Reopen for investigation.

  4. reopened this on Dec 4, 2018
  5. chdiza commented on Dec 4, 2018

    @chdiza
    Contributor

    I'm opposed to this if it means we won't be able to build it on our own machines without a Developer Cert.

  6. ychin commented on Dec 4, 2018

    @ychin
    Member

    MacVim is open-sourced so you can always still build it yourself :). We also still need to support Homebrew builds (which builds from source) of course.

    Part of the investigation is coming up with a satisfactory way to enable code signing in the build system (Travis CI) while keeping the main Xcode project in the repo pristine.

    I do think for distributed binary we should try to sign it. Sparkle (our update system) already checks for a code signature but it’s nice to have an Apple-signed binary for peace of mind (not to mention Apple is heavily encouraging this which makes the first-time user experience quite annoying otherwise).

    As a side note, #763 is related to this for some weird reason. I suspect the fact that MacVim is unsigned causes some slow validation path to trigger in Mojave when calling external application.

  7. chdiza commented on Dec 4, 2018

    @chdiza
    Contributor

    Well, Hammerspoon is also open-source, but if I want to build it from source and not have it be a console-spamming debug build, I have to make a self-signed cert and "sign" it with that. What a PITA; I hope this never happens to MacVim.

  8. ychin commented on Dec 5, 2018

    @ychin
    Member

    I think this is because Hammerspoon requires system permission which would be annoying if you don’t self-sign the app. So a little bit of a different circumstance from MacVim.

  9. added
    UpdaterIssues related to Sparkle updater
    on Dec 12, 2018
  10. added this to the snapshot-154 milestone on Dec 19, 2018
  11. eirnym commented on Dec 29, 2018

    @eirnym
    Contributor

    Could we accept a limited amount of donations for this purpose?

  12. ychin commented on Dec 30, 2018

    @ychin
    Member

    I thought about it but I have already purchased an account. Maybe I’ll do it next year for renewal.

  13. added a commit that references this issue on Feb 4, 2019
  14. ychin commented on Feb 4, 2019

    @ychin
    Member
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    UpdaterIssues related to Sparkle updater

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions