Repository navigation
Tabs crash latest macvim #1354
Description
Steps to reproduce
- I notice with the latest homebrew version of macvim when i opened it it crashed immediately. when I went through line by line to figure out if it was related to an installation issue or a config issue, i narrowed it down to this single line:
" show buffer tabs
set showtabline=2
I notice even if i delete the entire contents of .vimrc except for that line it still crashes, so the steps to reproduce it are very easy
Expected behaviour
It should not crash
Version of Vim and architecture
it crashes so i cant run that, see below:
Environment
VIM - Vi IMproved 9.0 (2022 Jun 28, compiled Sep 15 2022 18:56:17)
macOS version - x86_64
Included patches: 1-472
Compiled by Homebrew
==================
Ventura: 13.1 (22C65)
How MacVim was installed
Homebrew
Logs and stack traces
No visible log, just immediately closes 1 second after opening
mvim --clean does work properlyVim configuration where issue is reproducable
No response
Issue has been tested with given configuration
- by running MacVim.app from GUI macOS interface
- by running vim/gvim/etc installed by MacVim
- by running other versions of vim (e.g. /usr/bin/vim)
Issue has been tested with no configuration
- by running
mvim --clean(orgvim, supplied by MacVim distribution) - by running
vim --clean(in terminal, supplied by MacVim distribution) - by running
vim --clean(in terminal, other suppliers, e.g. /usr/bin/vim)
Other conditions
- The both Homebrew packages "vim" and "macvim" are installed
Activity
9mm commentedon Jan 6, 2023
As a follow up, just all tabs entirely crash... if I hit command+T to make a new tab (after disabling that option) mvim just crashes
RStankov commentedon Jan 6, 2023
I have the same issue from earlier this morning. Even without my
vimrcit crashes when I open a new tab.I noticed that same version downloaded via:
https://github.com/macvim-dev/macvim/releases/download/release-174/MacVim.dmg
Works as expected.
[-]showtabline=2 crashes latest macvim[/-][+]showtabline=2 (also just using tabs) crashes latest macvim[/+][-]showtabline=2 (also just using tabs) crashes latest macvim[/-][+]Tabs crashes latest macvim[/+][-]Tabs crashes latest macvim[/-][+]Tabs crash latest macvim[/+]eirnym commentedon Jan 6, 2023
dup of #1333.
alecernas commentedon Jan 11, 2023
I have the same issue when opening a new tab
SO Ventura 13.0
eirnym commentedon Jan 11, 2023
@ychin could I ask to release a new version of MacVim with this fix?
fahasch commentedon Jan 11, 2023
For the time being,
brew install --HEAD macviminstalls the latest version of macvim where the issue has been fixed.jmarrec commentedon Jan 17, 2023
Have you got a PR / commit that fixed it?
Or is it just the fact that by doing
--HEADyou are compiling it from source that makes it work?Anyways, it does work when compiled from source via
--HEAD, so thanks!fahasch commentedon Jan 17, 2023
The latter:
--HEADcompiles the latest version of the source code where the issue is fixed. For a bottle version, we most likely have to wait for the release 175 of macvim.ychin commentedon Jan 21, 2023
One #1356 is in, I'll make sure there are no straggler issues that i need to fix up and upstream Vim is stable and I'll push out the release. Sorry for the delay. 🙏
ychin commentedon Feb 7, 2023
This should be fixed since r176 (r175 was skipped because I missed a case where tabs could still end up crashing and I released a fix for that) was just released. Closing this for now. If you are using Homebrew, it usually takes a couple days for them to update the formula/bottle for a new release.
jmarrec commentedon Feb 7, 2023
Thanks a lot @ychin !