Skip to content

Highlight feature "gui=strikethrough" does not display strikethrough text. #1034

Closed

Description

@jtvoorhies

Highlight feature "gui=strikethrough" does not display strikethrough text.

To Reproduce

  1. Run mvim --clean
  2. Create or edit an html file
  3. Type <strike>some text</strike> or :highlight htmlStrike
  4. Observe "gui=strikethrough" yet the strike mark is not on the text.

Expected behavior
The highlight feature "gui=strikethrough" should show a strikethrough

Screenshots
Screenshot attached.

Environment (please complete the following information):

  • Vim version:
    VIM - Vi IMproved 8.2 (2019 Dec 12, compiled Mar 3 2020 12:05:00)
    macOS version
    Included patches: 1-319
    Compiled by travis@Traviss-Mac.local
    Huge version with MacVim GUI.
  • OS: macOS 10.15.4
  • Terminal: MacVim GUI

mvim --clean no strikethrough

Activity

  1. added
    RendererText rendering issues, including CoreText renderer
    on Apr 7, 2020
  2. ychin commented on Apr 7, 2020

    @ychin
    Member

    Yeah we should add this. Maybe next release where we look at getting the renderer fix in.

  3. qiqiboy commented on Sep 14, 2022

    @qiqiboy

    Hi, is there any update on this? Thanks.

  4. ychin commented on Sep 14, 2022

    @ychin
    Member

    I forgot about this, that's all. I'm preparing a release right now, but let me see if it's easy to squeeze this in before the release.

    Also, interestingly, Apple's terminal still doesn't support strikethrough it seems. iTerm does though, of course.

  5. added this to the Release 174 milestone on Sep 14, 2022
  6. ychin commented on Sep 14, 2022

    @ychin
    Member

    Actually, sorry, but I think I'll push this till r175 (the one after the coming release) since I kind of want to push it out soon, and I want to make sure I get the rendering to look correct, plus support the new Vim text styles in one go (double underline, dashed / dotted underlines).

  7. modified the milestones: Release 174, Release 175 on Sep 14, 2022
  8. added a commit that references this issue on Sep 15, 2022
    882944f
  9. ychin commented on Sep 15, 2022

    @ychin
    Member

    Nevermind what I said. I'm waiting to see if Vim will stabilize a bit before I pick a good version to release on, so we are going to squeeze it in for the coming release r174 (#1287).

  10. modified the milestones: Release 175, Release 174 on Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    RendererText rendering issues, including CoreText renderer

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions