Skip to content

Pin GitHub Actions to commit SHAs - #3

Open
veselinstoyanovatlyst wants to merge 1 commit into
masterfrom
CW-3994-pin-actions
Open

veselinstoyanovatlyst wants to merge 1 commit into
masterfrom
CW-3994-pin-actions

Conversation

@veselinstoyanovatlyst

@veselinstoyanovatlyst veselinstoyanovatlyst commented Nov 12, 2026 •

Copy link
Copy Markdown
Collaborator

Changes

  • Pin actions/checkout → a37ce91… (v3.7.0) and actions/setup-node → 3235b87… (v3.9.1) in both publish.yml and node.js.yml (CI moves from v2 to v3). SHAs verified against the upstream tag refs.
  • permissions: contents: read on both workflows.
  • persist-credentials: false on checkout (nothing pushes back to the repo).
  • .github/dependabot.yml for the github-actions ecosystem, so pin bumps arrive as reviewed PRs.

Not in this PR

Moving publishing to npm trusted publishing (OIDC) and revoking the long-lived NPM_TOKEN needs npmjs.com org admin access — tracked as a follow-up.

Testing

  • CI workflow runs on this PR at the pinned SHAs.
  • After merge, the publish workflow re-runs; with the version unchanged npm publish is expected to fail with "cannot publish over the previously published version", which still confirms checkout/setup-node work at the pins.

@veselinstoyanovatlyst veselinstoyanovatlyst changed the title [CW-3994] Pin GitHub Actions to commit SHAs Pin GitHub Actions to commit SHAs Nov 12, 2026
Pin actions/checkout and actions/setup-node to full commit SHAs in the
publish and CI workflows, restrict the default GITHUB_TOKEN to read-only,
stop persisting checkout credentials, and add Dependabot for action updates.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Comment thread .github/dependabot.yml
@@ -0,0 +1,6 @@
version: 2

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm guessing we didn't have dependabot before... let's see if it works!

@alexander-rembridge alexander-rembridge left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants