Repository navigation
feat(mcp): trigger lazy auth on JSON-RPC body errors - #3
Merged
Merged
Conversation
4 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
locksmith mcp run --urlto fire on JSON-RPC body errors (response.errororresult.isError: true), not only on HTTP401/403.authState. If retry also fails, the response is forwarded to the AI client unchanged.result.content[].text. Notifications andid:nullresponses never trigger.Implementation
internal/mcp/jsonrpc_error.go-inspectResponse/extractIDhelpersinternal/mcp/auth_state.go- sharedauthStatewithresolveOnceinternal/mcp/transport_http.go/transport_sse.go- route auth retry through shared stateinternal/mcp/proxy.go-proxyStateid-map + body-level retry handshake (with concurrent in-flight support)Test plan
TestInspectResponse+TestExtractIDtable-driven coverageTestAuthState_ResolveOnce_*(single, concurrent, resolver-fails, nil-resolver)TestStreamableHTTP_BodyResolveThen401_NoSecondResolve- cross-layer guaranteeTestProxy_*scenarios inproxy_retry_test.go(success, resolve fail, send fail, retry-also-errors, concurrent ids, only-first-error, after-attempted no-parse, notification not tracked)authStateconstructor and passing under-racemake verifygreen