Repository navigation
fix(init): block planned vault backends (1password, gnome-keyring) - #2
Merged
Merged
Conversation
Add Implemented bool to DetectedVault to distinguish backends with a working plugin (keychain, gopass) from planned ones (1password, gnome-keyring). Auto-mode now requires both Detected and Implemented before adding a vault to SelectedVaults.
Partition vaults into implemented/planned in VaultSelection; only implemented backends appear as multi-select options. Planned backends are shown in the form description note. Add tests covering the new exclusion logic and the no-implemented-vaults error path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
locksmith initno longer shows1passwordandgnome-keyringas selectable vault backends - they appear as a read-only "Planned (not yet supported)" note in the form description--auto) skips planned backends even when their CLI binary (op,secret-tool) is present in$PATHDetectedVaultgainsImplemented bool(gate for selection) andPlatformNote string(static platform annotation for display)Test plan
TestRunInit_Auto_SkipsPlannedVaults- auto mode does not select1passwordTestHuhPrompter_VaultSelection_PlannedExcluded- planned vault not returned as optionTestHuhPrompter_VaultSelection_NoImplemented_Errors- empty implemented list returns errorImplemented: trueadded to fixturesmake test-racegreen on ubuntu and macos